Browse Source

perf(frontend): lazy-load modals + split heavy vendor chunks (#4501)

* perf(frontend): lazy-load modals on inbounds / clients / index pages

Modals on the three list pages were imported statically, so the JS +
CSS for every form, info, qr, log, backup, metrics, system-history,
version, and config-text modal sat in the initial bundle even though
they're only needed after a click.

Converted those imports to React.lazy() and gated each modal with a
new LazyMount helper that mounts on first open and keeps the component
mounted thereafter so AntD close animations still play.

Build now emits a dedicated chunk per modal — InboundFormModal at
66 kB (13 kB gzipped) and InboundInfoModal at 23 kB (4 kB gzipped)
are the largest, totalling roughly 150 kB of code that no longer
parses on first paint. Profiler measured the inbounds-page React
render tree drop from ~444 ms to ~254 ms on a prod build.

* perf(frontend): split codemirror / jalali / otpauth into lazy vendor chunks

Heavy libs (codemirror, persian-calendar-suite, otpauth) and antd's
rc-/cssinjs transitive deps used to fall into the catch-all `vendor`
chunk and load with every entry point. Give them their own manualChunks
groups so they only load with the lazy modal/page that needs them.

Initial vendor (catch-all) drops from 1293 kB / 408 kB gzip to
76 kB / 27 kB gzip; codemirror (408 kB / 131 kB gzip) is now on the
JsonEditor lazy path instead of the inbounds/clients/index initial load.
Sanaei 23 hours ago
parent
commit
09df07ddf5

+ 20 - 0
frontend/src/components/LazyMount.tsx

@@ -0,0 +1,20 @@
+import { Suspense, useEffect, useState, type ReactNode } from 'react';
+
+interface LazyMountProps {
+  when: boolean;
+  fallback?: ReactNode;
+  children: ReactNode;
+}
+
+// Mounts children only after `when` first becomes true and keeps them mounted
+// thereafter, so React.lazy modals get loaded on demand but their close
+// animations still play out. Pair with `lazy(() => import(...))` modal imports
+// on heavy list pages to keep the initial bundle small.
+export default function LazyMount({ when, fallback = null, children }: LazyMountProps) {
+  const [mounted, setMounted] = useState(when);
+  useEffect(() => {
+    if (when && !mounted) setMounted(true);
+  }, [when, mounted]);
+  if (!mounted) return null;
+  return <Suspense fallback={fallback}>{children}</Suspense>;
+}

+ 62 - 51
frontend/src/pages/clients/ClientsPage.tsx

@@ -1,4 +1,4 @@
-import { useCallback, useEffect, useMemo, useState } from 'react';
+import { lazy, useCallback, useEffect, useMemo, useState } from 'react';
 import { useTranslation } from 'react-i18next';
 import {
   Badge,
@@ -51,11 +51,12 @@ import AppSidebar from '@/components/AppSidebar';
 import CustomStatistic from '@/components/CustomStatistic';
 import { IntlUtil, SizeFormatter } from '@/utils';
 import { setMessageInstance } from '@/utils/messageBus';
-import ClientFormModal from './ClientFormModal';
-import ClientInfoModal from './ClientInfoModal';
-import ClientQrModal from './ClientQrModal';
-import ClientBulkAddModal from './ClientBulkAddModal';
-import ClientBulkAdjustModal from './ClientBulkAdjustModal';
+import LazyMount from '@/components/LazyMount';
+const ClientFormModal = lazy(() => import('./ClientFormModal'));
+const ClientInfoModal = lazy(() => import('./ClientInfoModal'));
+const ClientQrModal = lazy(() => import('./ClientQrModal'));
+const ClientBulkAddModal = lazy(() => import('./ClientBulkAddModal'));
+const ClientBulkAdjustModal = lazy(() => import('./ClientBulkAdjustModal'));
 import '@/styles/page-cards.css';
 import './ClientsPage.css';
 
@@ -853,51 +854,61 @@ export default function ClientsPage() {
           </Layout.Content>
         </Layout>
 
-        <ClientFormModal
-          open={formOpen}
-          mode={formMode}
-          client={editingClient}
-          attachedIds={editingAttachedIds}
-          inbounds={inbounds}
-          ipLimitEnable={ipLimitEnable}
-          tgBotEnable={tgBotEnable}
-          save={onSave}
-          onOpenChange={setFormOpen}
-        />
-        <ClientInfoModal
-          open={infoOpen}
-          client={infoClient}
-          inboundsById={inboundsById}
-          isOnline={infoClient ? isOnline(infoClient.email) : false}
-          subSettings={subSettings}
-          onOpenChange={setInfoOpen}
-        />
-        <ClientQrModal
-          open={qrOpen}
-          client={qrClient}
-          subSettings={subSettings}
-          onOpenChange={setQrOpen}
-        />
-        <ClientBulkAddModal
-          open={bulkAddOpen}
-          inbounds={inbounds}
-          ipLimitEnable={ipLimitEnable}
-          onOpenChange={setBulkAddOpen}
-          onSaved={() => setBulkAddOpen(false)}
-        />
-        <ClientBulkAdjustModal
-          open={bulkAdjustOpen}
-          count={selectedRowKeys.length}
-          onOpenChange={setBulkAdjustOpen}
-          onSubmit={async (addDays, addBytes) => {
-            const msg = await bulkAdjust([...selectedRowKeys], addDays, addBytes);
-            if (msg?.success) {
-              setSelectedRowKeys([]);
-              return msg.obj ?? { adjusted: 0 };
-            }
-            return null;
-          }}
-        />
+        <LazyMount when={formOpen}>
+          <ClientFormModal
+            open={formOpen}
+            mode={formMode}
+            client={editingClient}
+            attachedIds={editingAttachedIds}
+            inbounds={inbounds}
+            ipLimitEnable={ipLimitEnable}
+            tgBotEnable={tgBotEnable}
+            save={onSave}
+            onOpenChange={setFormOpen}
+          />
+        </LazyMount>
+        <LazyMount when={infoOpen}>
+          <ClientInfoModal
+            open={infoOpen}
+            client={infoClient}
+            inboundsById={inboundsById}
+            isOnline={infoClient ? isOnline(infoClient.email) : false}
+            subSettings={subSettings}
+            onOpenChange={setInfoOpen}
+          />
+        </LazyMount>
+        <LazyMount when={qrOpen}>
+          <ClientQrModal
+            open={qrOpen}
+            client={qrClient}
+            subSettings={subSettings}
+            onOpenChange={setQrOpen}
+          />
+        </LazyMount>
+        <LazyMount when={bulkAddOpen}>
+          <ClientBulkAddModal
+            open={bulkAddOpen}
+            inbounds={inbounds}
+            ipLimitEnable={ipLimitEnable}
+            onOpenChange={setBulkAddOpen}
+            onSaved={() => setBulkAddOpen(false)}
+          />
+        </LazyMount>
+        <LazyMount when={bulkAdjustOpen}>
+          <ClientBulkAdjustModal
+            open={bulkAdjustOpen}
+            count={selectedRowKeys.length}
+            onOpenChange={setBulkAdjustOpen}
+            onSubmit={async (addDays, addBytes) => {
+              const msg = await bulkAdjust([...selectedRowKeys], addDays, addBytes);
+              if (msg?.success) {
+                setSelectedRowKeys([]);
+                return msg.obj ?? { adjusted: 0 };
+              }
+              return null;
+            }}
+          />
+        </LazyMount>
       </Layout>
     </ConfigProvider>
   );

+ 67 - 56
frontend/src/pages/inbounds/InboundsPage.tsx

@@ -1,5 +1,5 @@
 /* eslint-disable @typescript-eslint/no-explicit-any */
-import { useCallback, useEffect, useMemo, useState } from 'react';
+import { lazy, useCallback, useEffect, useMemo, useState } from 'react';
 import { useTranslation } from 'react-i18next';
 import {
   Card,
@@ -28,14 +28,15 @@ import { useWebSocket } from '@/hooks/useWebSocket';
 import { useNodes } from '@/hooks/useNodes';
 import AppSidebar from '@/components/AppSidebar';
 import CustomStatistic from '@/components/CustomStatistic';
-import TextModal from '@/components/TextModal';
-import PromptModal from '@/components/PromptModal';
+const TextModal = lazy(() => import('@/components/TextModal'));
+const PromptModal = lazy(() => import('@/components/PromptModal'));
 
 import { useInbounds } from './useInbounds';
 import InboundList from './InboundList';
-import InboundFormModal from './InboundFormModal';
-import InboundInfoModal from './InboundInfoModal';
-import QrCodeModal from './QrCodeModal';
+import LazyMount from '@/components/LazyMount';
+const InboundFormModal = lazy(() => import('./InboundFormModal'));
+const InboundInfoModal = lazy(() => import('./InboundInfoModal'));
+const QrCodeModal = lazy(() => import('./QrCodeModal'));
 import '@/styles/page-cards.css';
 import './InboundsPage.css';
 
@@ -517,56 +518,66 @@ export default function InboundsPage() {
           </Layout.Content>
         </Layout>
 
-        <InboundFormModal
-          open={formOpen}
-          onClose={() => setFormOpen(false)}
-          onSaved={refresh}
-          mode={formMode}
-          dbInbound={formDbInbound}
-          dbInbounds={dbInbounds as any[]}
-          availableNodes={nodesList}
-        />
-        <InboundInfoModal
-          open={infoOpen}
-          onClose={() => setInfoOpen(false)}
-          dbInbound={infoDbInbound}
-          clientIndex={infoClientIndex}
-          remarkModel={remarkModel}
-          expireDiff={expireDiff}
-          trafficDiff={trafficDiff}
-          ipLimitEnable={ipLimitEnable}
-          tgBotEnable={tgBotEnable}
-          subSettings={subSettings}
-          lastOnlineMap={lastOnlineMap}
-          nodeAddress={infoNodeAddress}
-        />
-        <QrCodeModal
-          open={qrOpen}
-          onClose={() => setQrOpen(false)}
-          dbInbound={qrDbInbound}
-          client={null}
-          remarkModel={remarkModel}
-          nodeAddress={qrNodeAddress}
-          subSettings={subSettings}
-        />
-
-        <TextModal
-          open={textOpen}
-          onClose={() => setTextOpen(false)}
-          title={textTitle}
-          content={textContent}
-          fileName={textFileName}
-        />
-        <PromptModal
-          open={promptOpen}
-          onClose={() => setPromptOpen(false)}
-          title={promptTitle}
-          okText={promptOkText}
-          type={promptType}
-          initialValue={promptInitial}
-          loading={promptLoading}
-          onConfirm={onPromptConfirm}
-        />
+        <LazyMount when={formOpen}>
+          <InboundFormModal
+            open={formOpen}
+            onClose={() => setFormOpen(false)}
+            onSaved={refresh}
+            mode={formMode}
+            dbInbound={formDbInbound}
+            dbInbounds={dbInbounds as any[]}
+            availableNodes={nodesList}
+          />
+        </LazyMount>
+        <LazyMount when={infoOpen}>
+          <InboundInfoModal
+            open={infoOpen}
+            onClose={() => setInfoOpen(false)}
+            dbInbound={infoDbInbound}
+            clientIndex={infoClientIndex}
+            remarkModel={remarkModel}
+            expireDiff={expireDiff}
+            trafficDiff={trafficDiff}
+            ipLimitEnable={ipLimitEnable}
+            tgBotEnable={tgBotEnable}
+            subSettings={subSettings}
+            lastOnlineMap={lastOnlineMap}
+            nodeAddress={infoNodeAddress}
+          />
+        </LazyMount>
+        <LazyMount when={qrOpen}>
+          <QrCodeModal
+            open={qrOpen}
+            onClose={() => setQrOpen(false)}
+            dbInbound={qrDbInbound}
+            client={null}
+            remarkModel={remarkModel}
+            nodeAddress={qrNodeAddress}
+            subSettings={subSettings}
+          />
+        </LazyMount>
+
+        <LazyMount when={textOpen}>
+          <TextModal
+            open={textOpen}
+            onClose={() => setTextOpen(false)}
+            title={textTitle}
+            content={textContent}
+            fileName={textFileName}
+          />
+        </LazyMount>
+        <LazyMount when={promptOpen}>
+          <PromptModal
+            open={promptOpen}
+            onClose={() => setPromptOpen(false)}
+            title={promptTitle}
+            okText={promptOkText}
+            type={promptType}
+            initialValue={promptInitial}
+            loading={promptLoading}
+            onConfirm={onPromptConfirm}
+          />
+        </LazyMount>
       </Layout>
     </ConfigProvider>
   );

+ 86 - 69
frontend/src/pages/index/IndexPage.tsx

@@ -1,4 +1,4 @@
-import { useCallback, useEffect, useMemo, useState } from 'react';
+import { lazy, useCallback, useEffect, useMemo, useState } from 'react';
 import { useTranslation } from 'react-i18next';
 import {
   Button,
@@ -40,18 +40,19 @@ import { useStatus } from '@/hooks/useStatus';
 import { useMediaQuery } from '@/hooks/useMediaQuery';
 import AppSidebar from '@/components/AppSidebar';
 import CustomStatistic from '@/components/CustomStatistic';
-import JsonEditor from '@/components/JsonEditor';
+import LazyMount from '@/components/LazyMount';
 import { setMessageInstance } from '@/utils/messageBus';
 import StatusCard from './StatusCard';
 import XrayStatusCard from './XrayStatusCard';
-import PanelUpdateModal from './PanelUpdateModal';
 import type { PanelUpdateInfo } from './PanelUpdateModal';
-import LogModal from './LogModal';
-import BackupModal from './BackupModal';
-import SystemHistoryModal from './SystemHistoryModal';
-import XrayMetricsModal from './XrayMetricsModal';
-import XrayLogModal from './XrayLogModal';
-import VersionModal from './VersionModal';
+const JsonEditor = lazy(() => import('@/components/JsonEditor'));
+const PanelUpdateModal = lazy(() => import('./PanelUpdateModal'));
+const LogModal = lazy(() => import('./LogModal'));
+const BackupModal = lazy(() => import('./BackupModal'));
+const SystemHistoryModal = lazy(() => import('./SystemHistoryModal'));
+const XrayMetricsModal = lazy(() => import('./XrayMetricsModal'));
+const XrayLogModal = lazy(() => import('./XrayLogModal'));
+const VersionModal = lazy(() => import('./VersionModal'));
 import '@/styles/page-cards.css';
 import './IndexPage.css';
 
@@ -435,67 +436,83 @@ export default function IndexPage() {
           </Layout.Content>
         </Layout>
 
-        <PanelUpdateModal
-          open={panelUpdateOpen}
-          info={panelUpdateInfo}
-          onClose={() => setPanelUpdateOpen(false)}
-          onBusy={setBusy}
-        />
-        <LogModal open={logsOpen} onClose={() => setLogsOpen(false)} />
-        <BackupModal
-          open={backupOpen}
-          basePath={basePath}
-          onClose={() => setBackupOpen(false)}
-          onBusy={setBusy}
-        />
-        <SystemHistoryModal
-          open={sysHistoryOpen}
-          status={status}
-          onClose={() => setSysHistoryOpen(false)}
-        />
-        <XrayMetricsModal open={xrayMetricsOpen} onClose={() => setXrayMetricsOpen(false)} />
-        <XrayLogModal open={xrayLogsOpen} onClose={() => setXrayLogsOpen(false)} />
-        <VersionModal
-          open={versionOpen}
-          status={status}
-          onClose={() => setVersionOpen(false)}
-          onBusy={setBusy}
-        />
-
-        <Modal
-          open={configTextOpen}
-          title={t('pages.index.config')}
-          width={isMobile ? '100%' : 900}
-          style={isMobile ? { top: 20, maxWidth: 'calc(100vw - 16px)' } : undefined}
-          onCancel={() => setConfigTextOpen(false)}
-          footer={[
-            <Button
-              key="download"
-              onClick={downloadConfig}
-              size={isMobile ? 'small' : 'middle'}
-              icon={<CloudDownloadOutlined />}
-            >
-              {isMobile ? 'Download' : 'config.json'}
-            </Button>,
-            <Button
-              key="copy"
-              type="primary"
-              onClick={copyConfig}
-              size={isMobile ? 'small' : 'middle'}
-              icon={<CopyOutlined />}
-            >
-              Copy
-            </Button>,
-          ]}
-        >
-          <JsonEditor
-            value={configText}
-            onChange={setConfigText}
-            minHeight={isMobile ? '300px' : '420px'}
-            maxHeight={isMobile ? '500px' : '720px'}
-            readOnly
+        <LazyMount when={panelUpdateOpen}>
+          <PanelUpdateModal
+            open={panelUpdateOpen}
+            info={panelUpdateInfo}
+            onClose={() => setPanelUpdateOpen(false)}
+            onBusy={setBusy}
+          />
+        </LazyMount>
+        <LazyMount when={logsOpen}>
+          <LogModal open={logsOpen} onClose={() => setLogsOpen(false)} />
+        </LazyMount>
+        <LazyMount when={backupOpen}>
+          <BackupModal
+            open={backupOpen}
+            basePath={basePath}
+            onClose={() => setBackupOpen(false)}
+            onBusy={setBusy}
           />
-        </Modal>
+        </LazyMount>
+        <LazyMount when={sysHistoryOpen}>
+          <SystemHistoryModal
+            open={sysHistoryOpen}
+            status={status}
+            onClose={() => setSysHistoryOpen(false)}
+          />
+        </LazyMount>
+        <LazyMount when={xrayMetricsOpen}>
+          <XrayMetricsModal open={xrayMetricsOpen} onClose={() => setXrayMetricsOpen(false)} />
+        </LazyMount>
+        <LazyMount when={xrayLogsOpen}>
+          <XrayLogModal open={xrayLogsOpen} onClose={() => setXrayLogsOpen(false)} />
+        </LazyMount>
+        <LazyMount when={versionOpen}>
+          <VersionModal
+            open={versionOpen}
+            status={status}
+            onClose={() => setVersionOpen(false)}
+            onBusy={setBusy}
+          />
+        </LazyMount>
+
+        <LazyMount when={configTextOpen}>
+          <Modal
+            open={configTextOpen}
+            title={t('pages.index.config')}
+            width={isMobile ? '100%' : 900}
+            style={isMobile ? { top: 20, maxWidth: 'calc(100vw - 16px)' } : undefined}
+            onCancel={() => setConfigTextOpen(false)}
+            footer={[
+              <Button
+                key="download"
+                onClick={downloadConfig}
+                size={isMobile ? 'small' : 'middle'}
+                icon={<CloudDownloadOutlined />}
+              >
+                {isMobile ? 'Download' : 'config.json'}
+              </Button>,
+              <Button
+                key="copy"
+                type="primary"
+                onClick={copyConfig}
+                size={isMobile ? 'small' : 'middle'}
+                icon={<CopyOutlined />}
+              >
+                Copy
+              </Button>,
+            ]}
+          >
+            <JsonEditor
+              value={configText}
+              onChange={setConfigText}
+              minHeight={isMobile ? '300px' : '420px'}
+              maxHeight={isMobile ? '500px' : '720px'}
+              readOnly
+            />
+          </Modal>
+        </LazyMount>
       </Layout>
     </ConfigProvider>
   );

+ 17 - 1
frontend/vite.config.js

@@ -174,7 +174,16 @@ export default defineConfig({
         manualChunks(id) {
           if (!id.includes('node_modules')) return undefined;
           if (id.includes('/node_modules/antd/')) return 'vendor-antd';
-          if (id.includes('/@ant-design/icons/')) return 'vendor-icons';
+          if (id.includes('/@ant-design/icons/') || id.includes('/@ant-design/icons-svg/')) return 'vendor-icons';
+          if (
+            id.includes('/node_modules/@rc-component/')
+            || id.includes('/node_modules/rc-')
+            || id.includes('/@ant-design/cssinjs')
+            || id.includes('/@ant-design/colors')
+            || id.includes('/@ant-design/fast-color')
+            || id.includes('/@ant-design/react-slick')
+            || id.includes('/@ctrl/tinycolor')
+          ) return 'vendor-antd';
           if (
             id.includes('/node_modules/react-i18next/')
             || id.includes('/node_modules/i18next/')
@@ -184,6 +193,13 @@ export default defineConfig({
             || id.includes('/node_modules/react-dom/')
             || id.includes('/node_modules/scheduler/')
           ) return 'vendor-react';
+          if (
+            id.includes('/node_modules/codemirror/')
+            || id.includes('/node_modules/@codemirror/')
+            || id.includes('/node_modules/@lezer/')
+          ) return 'vendor-codemirror';
+          if (id.includes('/node_modules/persian-calendar-suite/')) return 'vendor-jalali';
+          if (id.includes('/node_modules/otpauth/')) return 'vendor-otpauth';
           if (id.includes('dayjs')) return 'vendor-dayjs';
           if (id.includes('axios')) return 'vendor-axios';
           return 'vendor';