process.go 22 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771
  1. package xray
  2. import (
  3. "bytes"
  4. "context"
  5. "encoding/json"
  6. "errors"
  7. "fmt"
  8. "os"
  9. "os/exec"
  10. "path/filepath"
  11. "runtime"
  12. "sort"
  13. "strings"
  14. "sync"
  15. "sync/atomic"
  16. "syscall"
  17. "time"
  18. "github.com/mhsanaei/3x-ui/v3/internal/config"
  19. "github.com/mhsanaei/3x-ui/v3/internal/logger"
  20. "github.com/mhsanaei/3x-ui/v3/internal/util/common"
  21. )
  22. // GetBinaryName returns the Xray binary filename for the current OS and architecture.
  23. func GetBinaryName() string {
  24. arch := runtime.GOARCH
  25. if arch == "arm" {
  26. arch = "arm32"
  27. }
  28. return fmt.Sprintf("xray-%s-%s", runtime.GOOS, arch)
  29. }
  30. // GetBinaryPath returns the full path to the Xray binary executable.
  31. func GetBinaryPath() string {
  32. return config.GetBinFolderPath() + "/" + GetBinaryName()
  33. }
  34. // GetConfigPath returns the path to the Xray configuration file in the binary folder.
  35. func GetConfigPath() string {
  36. return config.GetBinFolderPath() + "/config.json"
  37. }
  38. // GetGeositePath returns the path to the geosite data file used by Xray.
  39. func GetGeositePath() string {
  40. return config.GetBinFolderPath() + "/geosite.dat"
  41. }
  42. // GetGeoipPath returns the path to the geoip data file used by Xray.
  43. func GetGeoipPath() string {
  44. return config.GetBinFolderPath() + "/geoip.dat"
  45. }
  46. // GetIPLimitLogPath returns the path to the IP limit log file.
  47. func GetIPLimitLogPath() string {
  48. return config.GetLogFolder() + "/3xipl.log"
  49. }
  50. // GetIPLimitBannedLogPath returns the path to the banned IP log file.
  51. func GetIPLimitBannedLogPath() string {
  52. return config.GetLogFolder() + "/3xipl-banned.log"
  53. }
  54. // GetIPLimitBannedPrevLogPath returns the path to the previous banned IP log file.
  55. func GetIPLimitBannedPrevLogPath() string {
  56. return config.GetLogFolder() + "/3xipl-banned.prev.log"
  57. }
  58. func getLogPath(key string) (string, error) {
  59. config, err := os.ReadFile(GetConfigPath())
  60. if err != nil {
  61. logger.Warningf("Failed to read configuration file: %s", err)
  62. return "", err
  63. }
  64. jsonConfig := map[string]any{}
  65. err = json.Unmarshal(config, &jsonConfig)
  66. if err != nil {
  67. logger.Warningf("Failed to parse JSON configuration: %s", err)
  68. return "", err
  69. }
  70. if jsonLog, ok := jsonConfig["log"].(map[string]any); ok {
  71. if logPath, ok := jsonLog[key].(string); ok {
  72. return logPath, nil
  73. }
  74. }
  75. return "", nil
  76. }
  77. // GetAccessLogPath reads the Xray config and returns the access log file path.
  78. func GetAccessLogPath() (string, error) {
  79. return getLogPath("access")
  80. }
  81. // GetErrorLogPath reads the Xray config and returns the error log file path.
  82. func GetErrorLogPath() (string, error) {
  83. return getLogPath("error")
  84. }
  85. // stopProcess calls Stop on the given Process instance.
  86. func stopProcess(p *Process) {
  87. _ = p.Stop()
  88. }
  89. // Process wraps an Xray process instance and provides management methods.
  90. type Process struct {
  91. *process
  92. }
  93. // NewProcess creates a new Xray process and sets up cleanup on garbage collection.
  94. func NewProcess(xrayConfig *Config) *Process {
  95. p := &Process{newProcess(xrayConfig)}
  96. runtime.SetFinalizer(p, stopProcess)
  97. return p
  98. }
  99. // NewTestProcess creates a new Xray process that uses a specific config file path.
  100. // Used for test runs (e.g. outbound test) so the main config.json is not overwritten.
  101. // The config file at configPath is removed when the process is stopped.
  102. func NewTestProcess(xrayConfig *Config, configPath string) *Process {
  103. p := &Process{newTestProcess(xrayConfig, configPath)}
  104. runtime.SetFinalizer(p, stopProcess)
  105. return p
  106. }
  107. type process struct {
  108. // mu guards the process lifecycle fields (cmd, done, exitErr) plus version,
  109. // apiPort, and config, which are written by Start/startCommand/refreshVersion/
  110. // refreshAPIPort/SetConfig
  111. // while being read concurrently by IsRunning/GetErr/GetResult/GetXrayVersion/
  112. // GetAPIPort/Stop from other goroutines (status endpoint, check-xray-running
  113. // and traffic jobs). Snapshot under the lock, then do any blocking syscall
  114. // (Wait/Signal/Kill) on the local copy without holding it.
  115. mu sync.RWMutex
  116. cmd *exec.Cmd
  117. done chan struct{}
  118. version string
  119. apiPort int
  120. // onlineClients is the set of emails active on THIS panel's own xray
  121. // within the online grace window. It is derived only from local xray
  122. // traffic polls (see RefreshLocalOnline) — never from remote-node
  123. // snapshots — so a client connected solely to a remote node is not
  124. // reported online on local inbounds.
  125. onlineClients []string
  126. // localActiveInbounds is the set of THIS panel's inbound tags that
  127. // carried traffic within the same grace window. Xray's user>>>email
  128. // stat aggregates across every inbound a client is attached to, so an
  129. // online email alone can't say which inbound it actually used. Pairing
  130. // it with the inbound>>>tag stat lets the per-inbound view drop a
  131. // multi-inbound client from inbounds that saw no traffic this window.
  132. localActiveInbounds []string
  133. // localLastOnline records, per email, the last time this panel's own
  134. // xray reported traffic for it. RefreshLocalOnline rebuilds
  135. // onlineClients from this map each tick, keeping the local online set
  136. // independent of the shared client_traffics.last_online column — that
  137. // column is bumped by remote-node syncs too and would otherwise leak
  138. // remote-only clients into the local set.
  139. localLastOnline map[string]int64
  140. // localInboundLastActive mirrors localLastOnline for inbound tags: the
  141. // last tick this panel's xray reported traffic through each tag.
  142. // Rebuilt into localActiveInbounds under the same grace window so the
  143. // two signals stay aligned — an email within grace always has the
  144. // inbound it used within grace too.
  145. localInboundLastActive map[string]int64
  146. // nodeOnlineTrees holds, per direct remote node (keyed by that node's
  147. // panel-local id), the GUID-keyed online-emails subtree that node
  148. // reported — its own clients under its panelGuid plus every descendant
  149. // under theirs. Keying the stored value by GUID (not node id) lets the
  150. // master attribute a deeply nested client to the node that physically
  151. // hosts it across a chain (#4983); the outer node-id key is only so a
  152. // failed probe can drop that whole branch's contribution. NodeTrafficSyncJob
  153. // populates entries per cron tick and clears them when a probe fails. The
  154. // mutex guards this map, onlineClients, and localLastOnline above so the
  155. // online getters never see a torn read.
  156. nodeOnlineTrees map[int]map[string][]string
  157. onlineMu sync.RWMutex
  158. // onlineAPISupport caches whether the running core implements the
  159. // online-stats RPCs (GetUsersStats). A new process is created on every
  160. // restart/version switch, so the flag resets to Unknown and is re-probed
  161. // lazily by the first caller.
  162. onlineAPISupport atomic.Int32
  163. config *Config
  164. configPath string // if set, use this path instead of GetConfigPath() and remove on Stop
  165. logWriter *LogWriter
  166. exitErr error
  167. startTime time.Time
  168. intentionalStop atomic.Bool
  169. }
  170. // OnlineAPISupport describes whether the running Xray core implements the
  171. // online-stats API (statsUserOnline + GetUsersStats).
  172. type OnlineAPISupport int32
  173. const (
  174. // OnlineAPIUnknown means support has not been probed yet for this process.
  175. OnlineAPIUnknown OnlineAPISupport = iota
  176. // OnlineAPISupported means the core answered the online-stats RPC.
  177. OnlineAPISupported
  178. // OnlineAPIUnsupported means the core returned Unimplemented (older binary).
  179. OnlineAPIUnsupported
  180. )
  181. // OnlineAPISupport returns the cached online-stats capability of this process.
  182. func (p *process) OnlineAPISupport() OnlineAPISupport {
  183. return OnlineAPISupport(p.onlineAPISupport.Load())
  184. }
  185. // SetOnlineAPISupport records the probed online-stats capability of this process.
  186. func (p *process) SetOnlineAPISupport(v OnlineAPISupport) {
  187. p.onlineAPISupport.Store(int32(v))
  188. }
  189. var (
  190. xrayGracefulStopTimeout = 5 * time.Second
  191. xrayForceStopTimeout = 2 * time.Second
  192. xrayVersionTimeout = 5 * time.Second
  193. // OnCrash is called when xray crashes unexpectedly. Set from web layer.
  194. OnCrash func(err error)
  195. )
  196. // newProcess creates a new internal process struct for Xray.
  197. func newProcess(config *Config) *process {
  198. return &process{
  199. version: "Unknown",
  200. config: config,
  201. logWriter: NewLogWriter(),
  202. startTime: time.Now(),
  203. }
  204. }
  205. // newTestProcess creates a process that writes and runs with a specific config path.
  206. func newTestProcess(config *Config, configPath string) *process {
  207. p := newProcess(config)
  208. p.configPath = configPath
  209. return p
  210. }
  211. // IsRunning returns true if the Xray process is currently running.
  212. func (p *process) IsRunning() bool {
  213. p.mu.RLock()
  214. cmd, done := p.cmd, p.done
  215. p.mu.RUnlock()
  216. if cmd == nil || cmd.Process == nil {
  217. return false
  218. }
  219. // done is closed by the waitForCommand goroutine exactly when cmd.Wait
  220. // returns, i.e. when the process has exited; it is the race-free signal here
  221. // (reading cmd.ProcessState would race with that Wait).
  222. if done != nil {
  223. select {
  224. case <-done:
  225. return false
  226. default:
  227. }
  228. }
  229. return true
  230. }
  231. // GetErr returns the last error encountered by the Xray process.
  232. func (p *process) GetErr() error {
  233. p.mu.RLock()
  234. defer p.mu.RUnlock()
  235. return p.exitErr
  236. }
  237. // GetResult returns the last log line or error from the Xray process.
  238. func (p *process) GetResult() string {
  239. p.mu.RLock()
  240. exitErr := p.exitErr
  241. p.mu.RUnlock()
  242. lastLine := p.logWriter.LastLine()
  243. if len(lastLine) == 0 && exitErr != nil {
  244. return exitErr.Error()
  245. }
  246. return lastLine
  247. }
  248. // GetXrayVersion returns the version string of the Xray process.
  249. func (p *process) GetXrayVersion() string {
  250. p.mu.RLock()
  251. defer p.mu.RUnlock()
  252. return p.version
  253. }
  254. // GetAPIPort returns the API port used by the Xray process.
  255. func (p *Process) GetAPIPort() int {
  256. p.mu.RLock()
  257. defer p.mu.RUnlock()
  258. return p.apiPort
  259. }
  260. // GetConfig returns the configuration used by the Xray process.
  261. func (p *Process) GetConfig() *Config {
  262. p.mu.RLock()
  263. defer p.mu.RUnlock()
  264. return p.config
  265. }
  266. // SetConfig replaces the stored configuration snapshot after the running
  267. // process has been reconciled with it through the gRPC API (hot apply), so
  268. // later change detection compares against what is actually running.
  269. func (p *Process) SetConfig(config *Config) {
  270. p.mu.Lock()
  271. defer p.mu.Unlock()
  272. p.config = config
  273. }
  274. // GetOnlineClients returns the union of locally-online clients and
  275. // node-online clients from every registered remote panel. Dedupes by
  276. // email so a client connected to both a local and a node-managed inbound
  277. // surfaces once. Cheap allocation — typical online sets are small and
  278. // the union is recomputed on demand.
  279. func (p *Process) GetOnlineClients() []string {
  280. p.onlineMu.RLock()
  281. defer p.onlineMu.RUnlock()
  282. if len(p.nodeOnlineTrees) == 0 {
  283. // Hot path for single-panel deployments: avoid the map+dedupe
  284. // work entirely and return the local slice as-is.
  285. return p.onlineClients
  286. }
  287. seen := make(map[string]struct{}, len(p.onlineClients))
  288. out := make([]string, 0, len(p.onlineClients))
  289. add := func(emails []string) {
  290. for _, email := range emails {
  291. if _, dup := seen[email]; dup {
  292. continue
  293. }
  294. seen[email] = struct{}{}
  295. out = append(out, email)
  296. }
  297. }
  298. add(p.onlineClients)
  299. for _, tree := range p.nodeOnlineTrees {
  300. for _, emails := range tree {
  301. add(emails)
  302. }
  303. }
  304. return out
  305. }
  306. // GetLocalOnlineClients returns a copy of the emails online on THIS panel's own
  307. // xray within the grace window. The service layer keys these under the panel's
  308. // own GUID when assembling the per-node online view.
  309. func (p *Process) GetLocalOnlineClients() []string {
  310. p.onlineMu.RLock()
  311. defer p.onlineMu.RUnlock()
  312. if len(p.onlineClients) == 0 {
  313. return nil
  314. }
  315. out := make([]string, len(p.onlineClients))
  316. copy(out, p.onlineClients)
  317. return out
  318. }
  319. // GetMergedNodeTrees returns the union of every direct node's reported subtree,
  320. // keyed by the panelGuid of the node that physically hosts each client set.
  321. // Because each child already reports its descendants under their own GUIDs,
  322. // merging the direct children yields the whole tree at any depth (#4983), so a
  323. // client three hops down is attributed to its real node, not the intermediate
  324. // one. GUIDs are globally unique, but a set reported under the same GUID by more
  325. // than one path is deduped per key; empty sets are omitted.
  326. func (p *Process) GetMergedNodeTrees() map[string][]string {
  327. p.onlineMu.RLock()
  328. defer p.onlineMu.RUnlock()
  329. if len(p.nodeOnlineTrees) == 0 {
  330. return map[string][]string{}
  331. }
  332. out := make(map[string][]string)
  333. seen := make(map[string]map[string]struct{})
  334. for _, tree := range p.nodeOnlineTrees {
  335. for guid, emails := range tree {
  336. if guid == "" || len(emails) == 0 {
  337. continue
  338. }
  339. dedup := seen[guid]
  340. if dedup == nil {
  341. dedup = make(map[string]struct{}, len(emails))
  342. seen[guid] = dedup
  343. }
  344. for _, email := range emails {
  345. if _, ok := dedup[email]; ok {
  346. continue
  347. }
  348. dedup[email] = struct{}{}
  349. out[guid] = append(out[guid], email)
  350. }
  351. }
  352. }
  353. return out
  354. }
  355. // GetLocalActiveInbounds returns a copy of THIS panel's inbound tags that
  356. // carried traffic within the grace window. Only the local xray reports
  357. // per-inbound activity; remote-node snapshots don't carry it, so the service
  358. // layer keys these under the panel's own GUID and a node missing from the
  359. // active-inbounds map means "don't gate" (fall back to the email-only signal).
  360. func (p *Process) GetLocalActiveInbounds() []string {
  361. p.onlineMu.RLock()
  362. defer p.onlineMu.RUnlock()
  363. if len(p.localActiveInbounds) == 0 {
  364. return nil
  365. }
  366. out := make([]string, len(p.localActiveInbounds))
  367. copy(out, p.localActiveInbounds)
  368. return out
  369. }
  370. // RefreshLocalOnline records that each email in activeEmails and each tag in
  371. // activeInboundTags had local xray traffic at now, then rebuilds onlineClients
  372. // and localActiveInbounds from every entry seen within graceMs, pruning older
  373. // ones. Called by the local XrayTrafficJob after each xray gRPC stats poll.
  374. // Pass nil/empty slices to only prune — NodeTrafficSyncJob does this so a
  375. // stopped local xray's clients and inbounds still age out between local polls.
  376. func (p *Process) RefreshLocalOnline(activeEmails, activeInboundTags []string, now, graceMs int64) {
  377. p.onlineMu.Lock()
  378. defer p.onlineMu.Unlock()
  379. if p.localLastOnline == nil {
  380. p.localLastOnline = make(map[string]int64, len(activeEmails))
  381. }
  382. for _, email := range activeEmails {
  383. p.localLastOnline[email] = now
  384. }
  385. online := make([]string, 0, len(p.localLastOnline))
  386. for email, ts := range p.localLastOnline {
  387. if now-ts < graceMs {
  388. online = append(online, email)
  389. } else {
  390. delete(p.localLastOnline, email)
  391. }
  392. }
  393. p.onlineClients = online
  394. if p.localInboundLastActive == nil {
  395. p.localInboundLastActive = make(map[string]int64, len(activeInboundTags))
  396. }
  397. for _, tag := range activeInboundTags {
  398. p.localInboundLastActive[tag] = now
  399. }
  400. activeInbounds := make([]string, 0, len(p.localInboundLastActive))
  401. for tag, ts := range p.localInboundLastActive {
  402. if now-ts < graceMs {
  403. activeInbounds = append(activeInbounds, tag)
  404. } else {
  405. delete(p.localInboundLastActive, tag)
  406. }
  407. }
  408. p.localActiveInbounds = activeInbounds
  409. }
  410. // SetNodeOnlineTree records the GUID-keyed online subtree one direct remote
  411. // node reported (its own clients under its panelGuid plus every descendant
  412. // under theirs). Replaces any previous entry for that node — NodeTrafficSyncJob
  413. // always sends the full subtree per tick.
  414. func (p *Process) SetNodeOnlineTree(nodeID int, tree map[string][]string) {
  415. p.onlineMu.Lock()
  416. defer p.onlineMu.Unlock()
  417. if p.nodeOnlineTrees == nil {
  418. p.nodeOnlineTrees = map[int]map[string][]string{}
  419. }
  420. p.nodeOnlineTrees[nodeID] = tree
  421. }
  422. // ClearNodeOnlineClients drops a direct node's whole subtree contribution.
  423. // Called when a probe fails so a downed node — and everything behind it — doesn't
  424. // keep its clients listed as "online" until the next successful probe.
  425. func (p *Process) ClearNodeOnlineClients(nodeID int) {
  426. p.onlineMu.Lock()
  427. defer p.onlineMu.Unlock()
  428. delete(p.nodeOnlineTrees, nodeID)
  429. }
  430. // GetUptime returns the uptime of the Xray process in seconds.
  431. func (p *Process) GetUptime() uint64 {
  432. return uint64(time.Since(p.startTime).Seconds())
  433. }
  434. // refreshAPIPort updates the API port from the inbound configs.
  435. func (p *process) refreshAPIPort() {
  436. port := 0
  437. for _, inbound := range p.config.InboundConfigs {
  438. if inbound.Tag == "api" {
  439. port = inbound.Port
  440. break
  441. }
  442. }
  443. p.mu.Lock()
  444. p.apiPort = port
  445. p.mu.Unlock()
  446. }
  447. // refreshVersion updates the version string by running the Xray binary with -version.
  448. func (p *process) refreshVersion() {
  449. version := "Unknown"
  450. ctx, cancel := context.WithTimeout(context.Background(), xrayVersionTimeout)
  451. defer cancel()
  452. cmd := exec.CommandContext(ctx, GetBinaryPath(), "-version")
  453. if data, err := cmd.Output(); err == nil {
  454. if datas := bytes.Split(data, []byte(" ")); len(datas) > 1 {
  455. version = string(datas[1])
  456. }
  457. }
  458. p.mu.Lock()
  459. p.version = version
  460. p.mu.Unlock()
  461. }
  462. // Start launches the Xray process with the current configuration.
  463. func (p *process) Start() (err error) {
  464. if p.IsRunning() {
  465. return errors.New("xray is already running")
  466. }
  467. defer func() {
  468. if err != nil {
  469. logger.Error("Failure in running xray-core process: ", err)
  470. p.setExitErr(err)
  471. }
  472. }()
  473. data, err := json.MarshalIndent(p.config, "", " ")
  474. if err != nil {
  475. return common.NewErrorf("Failed to generate XRAY configuration files: %v", err)
  476. }
  477. err = os.MkdirAll(config.GetLogFolder(), 0o770)
  478. if err != nil {
  479. logger.Warningf("Failed to create log folder: %s", err)
  480. }
  481. configPath := GetConfigPath()
  482. if p.configPath != "" {
  483. configPath = p.configPath
  484. }
  485. err = writeFileAtomic(configPath, data, 0o600)
  486. if err != nil {
  487. return common.NewErrorf("Failed to write configuration file: %v", err)
  488. }
  489. cmd := exec.CommandContext(context.Background(), GetBinaryPath(), "-c", configPath)
  490. cmd.Stdout = p.logWriter
  491. cmd.Stderr = p.logWriter
  492. err = p.startCommand(cmd)
  493. if err != nil {
  494. return err
  495. }
  496. p.refreshVersion()
  497. p.refreshAPIPort()
  498. return nil
  499. }
  500. // writeFileAtomic writes data to path via a same-directory temp file that is
  501. // permissioned, synced, and renamed into place, so a crash can never leave a
  502. // partial config; the config holds credentials, hence the 0600 perm. After the
  503. // rename the parent directory is fsynced to persist the directory entry. That
  504. // final step is skipped on Windows, where directory fsync is unsupported and
  505. // os.Rename already uses replace-existing semantics.
  506. func writeFileAtomic(path string, data []byte, perm os.FileMode) (err error) {
  507. dir := filepath.Dir(path)
  508. tmp, err := os.CreateTemp(dir, ".config-*.tmp")
  509. if err != nil {
  510. return err
  511. }
  512. tmpPath := tmp.Name()
  513. defer func() {
  514. _ = tmp.Close()
  515. if err != nil {
  516. _ = os.Remove(tmpPath)
  517. }
  518. }()
  519. if err = tmp.Chmod(perm); err != nil {
  520. return err
  521. }
  522. if _, err = tmp.Write(data); err != nil {
  523. return err
  524. }
  525. if err = tmp.Sync(); err != nil {
  526. return err
  527. }
  528. if err = tmp.Close(); err != nil {
  529. return err
  530. }
  531. if err = renameFile(tmpPath, path); err != nil {
  532. return err
  533. }
  534. if runtime.GOOS == "windows" {
  535. return nil
  536. }
  537. dirHandle, err := os.Open(dir)
  538. if err != nil {
  539. return err
  540. }
  541. err = dirHandle.Sync()
  542. _ = dirHandle.Close()
  543. return err
  544. }
  545. var renameFile = os.Rename
  546. func (p *process) startCommand(cmd *exec.Cmd) error {
  547. p.mu.Lock()
  548. p.cmd = cmd
  549. p.done = make(chan struct{})
  550. p.exitErr = nil
  551. done := p.done
  552. p.mu.Unlock()
  553. p.intentionalStop.Store(false)
  554. if err := cmd.Start(); err != nil {
  555. close(done)
  556. p.mu.Lock()
  557. p.cmd = nil
  558. p.mu.Unlock()
  559. return err
  560. }
  561. attachChildLifetime(cmd)
  562. go p.waitForCommand(cmd, done)
  563. return nil
  564. }
  565. func (p *process) setExitErr(err error) {
  566. p.mu.Lock()
  567. p.exitErr = err
  568. p.mu.Unlock()
  569. }
  570. func (p *process) waitForCommand(cmd *exec.Cmd, done chan struct{}) {
  571. defer close(done)
  572. err := cmd.Wait()
  573. if err == nil || p.intentionalStop.Load() {
  574. return
  575. }
  576. // On Windows, killing the process results in "exit status 1" which isn't an error for us.
  577. if runtime.GOOS == "windows" {
  578. errStr := strings.ToLower(err.Error())
  579. if strings.Contains(errStr, "exit status 1") {
  580. p.setExitErr(err)
  581. return
  582. }
  583. }
  584. logger.Error("Failure in running xray-core:", err)
  585. p.setExitErr(err)
  586. if OnCrash != nil {
  587. OnCrash(err)
  588. }
  589. }
  590. // Stop terminates the running Xray process.
  591. func (p *process) Stop() error {
  592. if !p.IsRunning() {
  593. return errors.New("xray is not running")
  594. }
  595. p.intentionalStop.Store(true)
  596. // Snapshot cmd once, then run the blocking Signal/Kill/Wait on the local copy
  597. // without holding the lock.
  598. p.mu.RLock()
  599. cmd := p.cmd
  600. p.mu.RUnlock()
  601. if cmd == nil || cmd.Process == nil {
  602. return errors.New("xray is not running")
  603. }
  604. // Remove temporary config file used for test runs so main config is never touched
  605. if p.configPath != "" {
  606. if p.configPath != GetConfigPath() {
  607. // Check if file exists before removing
  608. if _, err := os.Stat(p.configPath); err == nil {
  609. _ = os.Remove(p.configPath)
  610. }
  611. }
  612. }
  613. if runtime.GOOS == "windows" {
  614. if err := cmd.Process.Kill(); err != nil && !errors.Is(err, os.ErrProcessDone) {
  615. return err
  616. }
  617. return p.waitForExit(xrayForceStopTimeout)
  618. }
  619. if err := cmd.Process.Signal(syscall.SIGTERM); err != nil {
  620. if errors.Is(err, os.ErrProcessDone) {
  621. return p.waitForExit(xrayForceStopTimeout)
  622. }
  623. return err
  624. }
  625. if err := p.waitForExit(xrayGracefulStopTimeout); err == nil {
  626. return nil
  627. }
  628. logger.Warning("xray-core did not stop after SIGTERM, killing process")
  629. if err := cmd.Process.Kill(); err != nil && !errors.Is(err, os.ErrProcessDone) {
  630. return err
  631. }
  632. return p.waitForExit(xrayForceStopTimeout)
  633. }
  634. func (p *process) waitForExit(timeout time.Duration) error {
  635. p.mu.RLock()
  636. done := p.done
  637. p.mu.RUnlock()
  638. if done == nil {
  639. return nil
  640. }
  641. timer := time.NewTimer(timeout)
  642. defer timer.Stop()
  643. select {
  644. case <-done:
  645. return nil
  646. case <-timer.C:
  647. return common.NewErrorf("timed out waiting for xray-core process to stop after %s", timeout)
  648. }
  649. }
  650. const (
  651. crashReportPrefix = "core_crash_"
  652. crashReportSuffix = ".log"
  653. maxCrashReports = 10
  654. )
  655. // writeCrashReport persists a captured xray crash chunk to the log folder
  656. // with nanosecond-precision filename so restart-loop bursts don't overwrite
  657. // each other, and prunes old reports to keep the folder bounded.
  658. func writeCrashReport(m []byte) error {
  659. dir := config.GetLogFolder()
  660. if err := os.MkdirAll(dir, 0o770); err != nil {
  661. return err
  662. }
  663. pruneOldCrashReports(dir, maxCrashReports-1)
  664. name := crashReportPrefix + time.Now().Format("20060102_150405_000000000") + crashReportSuffix
  665. return os.WriteFile(filepath.Join(dir, name), m, 0o640)
  666. }
  667. func pruneOldCrashReports(dir string, keep int) {
  668. entries, err := os.ReadDir(dir)
  669. if err != nil {
  670. return
  671. }
  672. var reports []string
  673. for _, e := range entries {
  674. n := e.Name()
  675. if !e.IsDir() && strings.HasPrefix(n, crashReportPrefix) && strings.HasSuffix(n, crashReportSuffix) {
  676. reports = append(reports, n)
  677. }
  678. }
  679. if len(reports) <= keep {
  680. return
  681. }
  682. sort.Strings(reports)
  683. for _, old := range reports[:len(reports)-keep] {
  684. _ = os.Remove(filepath.Join(dir, old))
  685. }
  686. }