3x-ui/internal/web/service/node_push_payload_test.go

package service

import (
	"encoding/json"
	"testing"

	"github.com/mhsanaei/3x-ui/v3/internal/database"
	"github.com/mhsanaei/3x-ui/v3/internal/database/model"
	"github.com/mhsanaei/3x-ui/v3/internal/xray"
)

func payloadClientEmails(t *testing.T, settings string) []string {
	t.Helper()
	var parsed map[string]any
	if err := json.Unmarshal([]byte(settings), &parsed); err != nil {
		t.Fatalf("settings not valid json: %v", err)
	}
	raw, _ := parsed["clients"].([]any)
	out := make([]string, 0, len(raw))
	for _, c := range raw {
		cm, ok := c.(map[string]any)
		if !ok {
			continue
		}
		if email, _ := cm["email"].(string); email != "" {
			out = append(out, email)
		}
	}
	return out
}

// Stripping disabled clients from a node push made the node delete the row and
// the master mirror that back: every depleted client destroyed, not disabled.
func TestNodePushKeepsDisabledClientsLocalPushStripsThem(t *testing.T) {
	setupBulkDB(t)
	svc := &InboundService{}
	db := database.GetDB()

	clients := []model.Client{
		{Email: "alive@x", ID: "11111111-1111-1111-1111-111111111111", Enable: true},
		{Email: "quota@x", ID: "22222222-2222-2222-2222-222222222222", Enable: true},
	}
	ib := mkInbound(t, 30301, model.VLESS, clientsSettings(t, clients))

	for _, c := range clients {
		row := &xray.ClientTraffic{InboundId: ib.Id, Email: c.Email, Enable: true}
		if err := db.Create(row).Error; err != nil {
			t.Fatalf("seed traffic %s: %v", c.Email, err)
		}
	}
	if err := db.Model(xray.ClientTraffic{}).
		Where("email = ?", "quota@x").
		Update("enable", false).Error; err != nil {
		t.Fatalf("deplete quota@x: %v", err)
	}

	t.Run("node payload keeps the depletion-disabled client", func(t *testing.T) {
		built, err := svc.buildInboundForNodePush(db, ib)
		if err != nil {
			t.Fatalf("buildInboundForNodePush: %v", err)
		}
		got := payloadClientEmails(t, built.Settings)
		if len(got) != 2 {
			t.Fatalf("node push dropped a client: got %v, want both alive@x and quota@x", got)
		}
	})

	t.Run("local xray payload still strips it", func(t *testing.T) {
		built, err := svc.buildInboundForLocalRuntime(db, ib)
		if err != nil {
			t.Fatalf("buildInboundForLocalRuntime: %v", err)
		}
		got := payloadClientEmails(t, built.Settings)
		if len(got) != 1 || got[0] != "alive@x" {
			t.Fatalf("local runtime payload = %v, want only alive@x", got)
		}
	})
}