port_conflict_test.go 21 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643
  1. package service
  2. import (
  3. "path/filepath"
  4. "strings"
  5. "sync"
  6. "testing"
  7. "github.com/mhsanaei/3x-ui/v3/database"
  8. "github.com/mhsanaei/3x-ui/v3/database/model"
  9. xuilogger "github.com/mhsanaei/3x-ui/v3/logger"
  10. "github.com/op/go-logging"
  11. )
  12. // the panel logger is a process-wide singleton. init it once per test
  13. // binary so a stray warning from gorm doesn't blow up on a nil logger.
  14. var portConflictLoggerOnce sync.Once
  15. // setupConflictDB wires a temp sqlite db so checkPortConflict can read
  16. // real candidates. closes the db before t.TempDir cleans up so windows
  17. // doesn't refuse to remove the file.
  18. func setupConflictDB(t *testing.T) {
  19. t.Helper()
  20. portConflictLoggerOnce.Do(func() { xuilogger.InitLogger(logging.ERROR) })
  21. dbDir := t.TempDir()
  22. t.Setenv("XUI_DB_FOLDER", dbDir)
  23. if err := database.InitDB(filepath.Join(dbDir, "3x-ui.db")); err != nil {
  24. t.Fatalf("InitDB: %v", err)
  25. }
  26. t.Cleanup(func() {
  27. if err := database.CloseDB(); err != nil {
  28. t.Logf("CloseDB warning: %v", err)
  29. }
  30. })
  31. }
  32. func seedInboundConflict(t *testing.T, tag, listen string, port int, protocol model.Protocol, streamSettings, settings string) {
  33. t.Helper()
  34. seedInboundConflictNode(t, tag, listen, port, protocol, streamSettings, settings, nil)
  35. }
  36. func seedInboundConflictNode(t *testing.T, tag, listen string, port int, protocol model.Protocol, streamSettings, settings string, nodeID *int) {
  37. t.Helper()
  38. in := &model.Inbound{
  39. Tag: tag,
  40. Enable: true,
  41. Listen: listen,
  42. Port: port,
  43. Protocol: protocol,
  44. StreamSettings: streamSettings,
  45. Settings: settings,
  46. NodeID: nodeID,
  47. }
  48. if err := database.GetDB().Create(in).Error; err != nil {
  49. t.Fatalf("seed inbound %s: %v", tag, err)
  50. }
  51. }
  52. //go:fix inline
  53. func intPtr(v int) *int { return new(v) }
  54. func TestInboundTransports(t *testing.T) {
  55. cases := []struct {
  56. name string
  57. protocol model.Protocol
  58. streamSettings string
  59. settings string
  60. want transportBits
  61. }{
  62. {"vless default tcp", model.VLESS, `{"network":"tcp"}`, ``, transportTCP},
  63. {"vless ws (still tcp)", model.VLESS, `{"network":"ws"}`, ``, transportTCP},
  64. {"vless kcp is udp", model.VLESS, `{"network":"kcp"}`, ``, transportUDP},
  65. {"vless empty stream defaults to tcp", model.VLESS, ``, ``, transportTCP},
  66. {"vless garbage stream stays tcp", model.VLESS, `not json`, ``, transportTCP},
  67. {"vmess default tcp", model.VMESS, `{"network":"tcp"}`, ``, transportTCP},
  68. {"trojan grpc is tcp", model.Trojan, `{"network":"grpc"}`, ``, transportTCP},
  69. {"hysteria forced udp", model.Hysteria, `{"network":"tcp"}`, ``, transportUDP},
  70. {"wireguard forced udp", model.WireGuard, ``, ``, transportUDP},
  71. {"shadowsocks tcp,udp", model.Shadowsocks, ``, `{"network":"tcp,udp"}`, transportTCP | transportUDP},
  72. {"shadowsocks udp only", model.Shadowsocks, ``, `{"network":"udp"}`, transportUDP},
  73. {"shadowsocks tcp only", model.Shadowsocks, ``, `{"network":"tcp"}`, transportTCP},
  74. {"shadowsocks empty network falls back to streamSettings", model.Shadowsocks, `{"network":"tcp"}`, `{}`, transportTCP},
  75. {"mixed udp on", model.Mixed, `{"network":"tcp"}`, `{"udp":true}`, transportTCP | transportUDP},
  76. {"mixed udp off", model.Mixed, `{"network":"tcp"}`, `{"udp":false}`, transportTCP},
  77. {"mixed udp missing", model.Mixed, `{"network":"tcp"}`, `{}`, transportTCP},
  78. }
  79. for _, c := range cases {
  80. t.Run(c.name, func(t *testing.T) {
  81. got := inboundTransports(c.protocol, c.streamSettings, c.settings)
  82. if got != c.want {
  83. t.Fatalf("got bits %#b, want %#b", got, c.want)
  84. }
  85. })
  86. }
  87. }
  88. func TestListenOverlaps(t *testing.T) {
  89. cases := []struct {
  90. a, b string
  91. want bool
  92. }{
  93. {"", "", true},
  94. {"0.0.0.0", "", true},
  95. {"0.0.0.0", "1.2.3.4", true},
  96. {"::", "1.2.3.4", true},
  97. {"::0", "fe80::1", true},
  98. {"1.2.3.4", "1.2.3.4", true},
  99. {"1.2.3.4", "5.6.7.8", false},
  100. {"1.2.3.4", "::1", false},
  101. }
  102. for _, c := range cases {
  103. if got := listenOverlaps(c.a, c.b); got != c.want {
  104. t.Errorf("listenOverlaps(%q, %q) = %v, want %v", c.a, c.b, got, c.want)
  105. }
  106. }
  107. }
  108. // the actual case from #4103: tcp/443 vless reality and udp/443
  109. // hysteria must be allowed to coexist on the same port.
  110. func TestCheckPortConflict_TCPandUDPCoexistOnSamePort(t *testing.T) {
  111. setupConflictDB(t)
  112. seedInboundConflict(t, "vless-443-tcp", "0.0.0.0", 443, model.VLESS, `{"network":"tcp"}`, `{}`)
  113. svc := &InboundService{}
  114. hyst2 := &model.Inbound{
  115. Tag: "hyst2-443-udp",
  116. Listen: "0.0.0.0",
  117. Port: 443,
  118. Protocol: model.Hysteria,
  119. }
  120. exist, err := svc.checkPortConflict(hyst2, 0)
  121. if err != nil {
  122. t.Fatalf("checkPortConflict: %v", err)
  123. }
  124. if exist != nil {
  125. t.Fatalf("vless/tcp and hysteria2/udp on the same port must be allowed to coexist")
  126. }
  127. }
  128. // two tcp inbounds on the same port still conflict.
  129. func TestCheckPortConflict_TCPCollidesWithTCP(t *testing.T) {
  130. setupConflictDB(t)
  131. seedInboundConflict(t, "vless-443-a", "0.0.0.0", 443, model.VLESS, `{"network":"tcp"}`, `{}`)
  132. svc := &InboundService{}
  133. other := &model.Inbound{
  134. Tag: "vless-443-b",
  135. Listen: "0.0.0.0",
  136. Port: 443,
  137. Protocol: model.Trojan,
  138. StreamSettings: `{"network":"ws"}`,
  139. }
  140. exist, err := svc.checkPortConflict(other, 0)
  141. if err != nil {
  142. t.Fatalf("checkPortConflict: %v", err)
  143. }
  144. if exist == nil {
  145. t.Fatalf("two tcp inbounds on the same port must still conflict")
  146. }
  147. }
  148. // two udp inbounds (e.g. hysteria2 vs wireguard) on the same port also
  149. // conflict, since they fight for the same socket.
  150. func TestCheckPortConflict_UDPCollidesWithUDP(t *testing.T) {
  151. setupConflictDB(t)
  152. seedInboundConflict(t, "hyst2-443", "0.0.0.0", 443, model.Hysteria, ``, ``)
  153. svc := &InboundService{}
  154. wg := &model.Inbound{
  155. Tag: "wg-443",
  156. Listen: "0.0.0.0",
  157. Port: 443,
  158. Protocol: model.WireGuard,
  159. }
  160. exist, err := svc.checkPortConflict(wg, 0)
  161. if err != nil {
  162. t.Fatalf("checkPortConflict: %v", err)
  163. }
  164. if exist == nil {
  165. t.Fatalf("two udp inbounds on the same port must conflict")
  166. }
  167. }
  168. // shadowsocks listening on tcp+udp eats the whole port for both
  169. // transports, so neither a tcp nor a udp neighbour is allowed.
  170. func TestCheckPortConflict_ShadowsocksDualListenBlocksBoth(t *testing.T) {
  171. setupConflictDB(t)
  172. seedInboundConflict(t, "ss-443-dual", "0.0.0.0", 443, model.Shadowsocks, ``, `{"network":"tcp,udp"}`)
  173. svc := &InboundService{}
  174. tcpClash := &model.Inbound{
  175. Tag: "vless-443",
  176. Listen: "0.0.0.0",
  177. Port: 443,
  178. Protocol: model.VLESS,
  179. StreamSettings: `{"network":"tcp"}`,
  180. }
  181. if exist, err := svc.checkPortConflict(tcpClash, 0); err != nil || exist == nil {
  182. t.Fatalf("tcp inbound should clash with shadowsocks tcp,udp; exist=%v err=%v", exist, err)
  183. }
  184. udpClash := &model.Inbound{
  185. Tag: "hyst2-443",
  186. Listen: "0.0.0.0",
  187. Port: 443,
  188. Protocol: model.Hysteria,
  189. }
  190. if exist, err := svc.checkPortConflict(udpClash, 0); err != nil || exist == nil {
  191. t.Fatalf("udp inbound should clash with shadowsocks tcp,udp; exist=%v err=%v", exist, err)
  192. }
  193. }
  194. // different ports never conflict regardless of transport.
  195. func TestCheckPortConflict_DifferentPortNeverConflicts(t *testing.T) {
  196. setupConflictDB(t)
  197. seedInboundConflict(t, "vless-443", "0.0.0.0", 443, model.VLESS, `{"network":"tcp"}`, `{}`)
  198. svc := &InboundService{}
  199. other := &model.Inbound{
  200. Tag: "vless-444",
  201. Listen: "0.0.0.0",
  202. Port: 444,
  203. Protocol: model.VLESS,
  204. StreamSettings: `{"network":"tcp"}`,
  205. }
  206. if exist, err := svc.checkPortConflict(other, 0); err != nil || exist != nil {
  207. t.Fatalf("different port must not conflict; exist=%v err=%v", exist, err)
  208. }
  209. }
  210. // specific listen addresses on the same port don't clash with each other,
  211. // but do clash with any-address on the same port (preserved from the old
  212. // check).
  213. func TestCheckPortConflict_ListenOverlapPreserved(t *testing.T) {
  214. setupConflictDB(t)
  215. seedInboundConflict(t, "vless-1.2.3.4", "1.2.3.4", 443, model.VLESS, `{"network":"tcp"}`, `{}`)
  216. svc := &InboundService{}
  217. // different specific address, same port + transport: no conflict.
  218. other := &model.Inbound{
  219. Tag: "vless-5.6.7.8",
  220. Listen: "5.6.7.8",
  221. Port: 443,
  222. Protocol: model.VLESS,
  223. StreamSettings: `{"network":"tcp"}`,
  224. }
  225. if exist, err := svc.checkPortConflict(other, 0); err != nil || exist != nil {
  226. t.Fatalf("different specific listen must not conflict; exist=%v err=%v", exist, err)
  227. }
  228. // any-address vs specific on same transport: conflict (any-addr wins).
  229. anyAddr := &model.Inbound{
  230. Tag: "vless-any",
  231. Listen: "0.0.0.0",
  232. Port: 443,
  233. Protocol: model.VLESS,
  234. StreamSettings: `{"network":"tcp"}`,
  235. }
  236. if exist, err := svc.checkPortConflict(anyAddr, 0); err != nil || exist == nil {
  237. t.Fatalf("any-addr on same port+transport must conflict with specific; exist=%v err=%v", exist, err)
  238. }
  239. }
  240. // when the base "inbound-<port>" tag is already taken on a coexisting
  241. // transport, generateInboundTag must disambiguate with a transport
  242. // suffix so the unique-tag DB constraint stays satisfied.
  243. func TestGenerateInboundTag_DisambiguatesByTransportOnSamePort(t *testing.T) {
  244. setupConflictDB(t)
  245. // existing tcp inbound owns "inbound-443".
  246. seedInboundConflict(t, "inbound-443", "0.0.0.0", 443, model.VLESS, `{"network":"tcp"}`, `{}`)
  247. svc := &InboundService{}
  248. udp := &model.Inbound{
  249. Listen: "0.0.0.0",
  250. Port: 443,
  251. Protocol: model.Hysteria,
  252. }
  253. got, err := svc.generateInboundTag(udp, 0)
  254. if err != nil {
  255. t.Fatalf("generateInboundTag: %v", err)
  256. }
  257. if got != "inbound-443-udp" {
  258. t.Fatalf("expected disambiguated tag inbound-443-udp, got %q", got)
  259. }
  260. }
  261. // when the port is free, the canonical tag includes the transport
  262. // suffix so tcp/8443 and udp/8443 get distinct tags out of the box
  263. // (no collision-driven retry needed at INSERT time).
  264. func TestGenerateInboundTag_KeepsBaseTagWhenFree(t *testing.T) {
  265. setupConflictDB(t)
  266. svc := &InboundService{}
  267. in := &model.Inbound{
  268. Listen: "0.0.0.0",
  269. Port: 8443,
  270. Protocol: model.VLESS,
  271. }
  272. got, err := svc.generateInboundTag(in, 0)
  273. if err != nil {
  274. t.Fatalf("generateInboundTag: %v", err)
  275. }
  276. if got != "inbound-8443-tcp" {
  277. t.Fatalf("expected inbound-8443-tcp, got %q", got)
  278. }
  279. }
  280. // updating an inbound on its own port must not flag its own tag as
  281. // taken, that's what ignoreId is for. Seeds with the canonical
  282. // "inbound-<port>-<transport>" shape so the self-update returns the
  283. // same tag verbatim.
  284. func TestGenerateInboundTag_IgnoresSelfOnUpdate(t *testing.T) {
  285. setupConflictDB(t)
  286. seedInboundConflict(t, "inbound-443-tcp", "0.0.0.0", 443, model.VLESS, `{"network":"tcp"}`, `{}`)
  287. var existing model.Inbound
  288. if err := database.GetDB().Where("tag = ?", "inbound-443-tcp").First(&existing).Error; err != nil {
  289. t.Fatalf("read seeded row: %v", err)
  290. }
  291. svc := &InboundService{}
  292. got, err := svc.generateInboundTag(&existing, existing.Id)
  293. if err != nil {
  294. t.Fatalf("generateInboundTag: %v", err)
  295. }
  296. if got != "inbound-443-tcp" {
  297. t.Fatalf("self-update must keep base tag, got %q", got)
  298. }
  299. }
  300. // specific listen address gets the listen-prefixed shape and same
  301. // disambiguation rules.
  302. func TestGenerateInboundTag_SpecificListenSameDisambiguation(t *testing.T) {
  303. setupConflictDB(t)
  304. seedInboundConflict(t, "inbound-1.2.3.4:443", "1.2.3.4", 443, model.VLESS, `{"network":"tcp"}`, `{}`)
  305. svc := &InboundService{}
  306. udp := &model.Inbound{
  307. Listen: "1.2.3.4",
  308. Port: 443,
  309. Protocol: model.Hysteria,
  310. }
  311. got, err := svc.generateInboundTag(udp, 0)
  312. if err != nil {
  313. t.Fatalf("generateInboundTag: %v", err)
  314. }
  315. if got != "inbound-1.2.3.4:443-udp" {
  316. t.Fatalf("expected inbound-1.2.3.4:443-udp, got %q", got)
  317. }
  318. }
  319. // inbounds bound to different nodes run on different physical machines,
  320. // so the same port + transport must be allowed across nodes. covers
  321. // local-vs-remote, remote-A-vs-remote-B, and the still-clashing
  322. // same-node case.
  323. func TestCheckPortConflict_NodeScope(t *testing.T) {
  324. setupConflictDB(t)
  325. seedInboundConflictNode(t, "local-443-tcp", "0.0.0.0", 443, model.VLESS, `{"network":"tcp"}`, `{}`, nil)
  326. seedInboundConflictNode(t, "node1-443-tcp", "0.0.0.0", 443, model.VLESS, `{"network":"tcp"}`, `{}`, new(1))
  327. svc := &InboundService{}
  328. cases := []struct {
  329. name string
  330. nodeID *int
  331. want bool
  332. }{
  333. {"new local same port + tcp clashes with local", nil, true},
  334. {"new remote on different node from local is fine", new(2), false},
  335. {"new remote on existing node 1 clashes", new(1), true},
  336. }
  337. for _, c := range cases {
  338. t.Run(c.name, func(t *testing.T) {
  339. candidate := &model.Inbound{
  340. Listen: "0.0.0.0",
  341. Port: 443,
  342. Protocol: model.VLESS,
  343. StreamSettings: `{"network":"tcp"}`,
  344. NodeID: c.nodeID,
  345. }
  346. got, err := svc.checkPortConflict(candidate, 0)
  347. if err != nil {
  348. t.Fatalf("checkPortConflict: %v", err)
  349. }
  350. if (got != nil) != c.want {
  351. t.Fatalf("got conflict=%v, want %v", got != nil, c.want)
  352. }
  353. })
  354. }
  355. }
  356. // when the caller passes an explicit non-empty Tag that doesn't collide,
  357. // resolveInboundTag returns it verbatim. this is the cross-panel path:
  358. // the central panel picks a tag, pushes the inbound to a node, and the
  359. // node must keep that exact tag so the eventual traffic sync-back can
  360. // match the row by tag. previously the node regenerated and the two
  361. // panels diverged, causing a UNIQUE constraint failure on sync.
  362. func TestResolveInboundTag_RespectsCallerTagWhenFree(t *testing.T) {
  363. setupConflictDB(t)
  364. seedInboundConflictNode(t, "inbound-5000", "0.0.0.0", 5000, model.VLESS, `{"network":"tcp"}`, `{}`, nil)
  365. seedInboundConflictNode(t, "inbound-5000-udp", "0.0.0.0", 5000, model.Hysteria, ``, ``, nil)
  366. svc := &InboundService{}
  367. pushed := &model.Inbound{
  368. Tag: "inbound-5000-tcp",
  369. Listen: "0.0.0.0",
  370. Port: 5000,
  371. Protocol: model.VLESS,
  372. StreamSettings: `{"network":"tcp"}`,
  373. NodeID: intPtr(1),
  374. }
  375. got, err := svc.resolveInboundTag(pushed, 0)
  376. if err != nil {
  377. t.Fatalf("resolveInboundTag: %v", err)
  378. }
  379. if got != "inbound-5000-tcp" {
  380. t.Fatalf("caller tag must be preserved when free, got %q", got)
  381. }
  382. }
  383. // when the caller leaves Tag empty (the local UI path) resolveInboundTag
  384. // falls back to generateInboundTag, which emits the canonical
  385. // "inbound-<port>-<transport>" shape.
  386. func TestResolveInboundTag_GeneratesWhenTagEmpty(t *testing.T) {
  387. setupConflictDB(t)
  388. svc := &InboundService{}
  389. in := &model.Inbound{
  390. Listen: "0.0.0.0",
  391. Port: 8443,
  392. Protocol: model.VLESS,
  393. }
  394. got, err := svc.resolveInboundTag(in, 0)
  395. if err != nil {
  396. t.Fatalf("resolveInboundTag: %v", err)
  397. }
  398. if got != "inbound-8443-tcp" {
  399. t.Fatalf("expected generated inbound-8443-tcp, got %q", got)
  400. }
  401. }
  402. // when the caller's Tag collides (e.g. a node that was used standalone
  403. // happens to already own the tag the central panel picked),
  404. // resolveInboundTag falls back to generateInboundTag rather than
  405. // failing — the inbound still lands, just under a slightly different
  406. // tag that the central will pick up via the AddInbound response.
  407. func TestResolveInboundTag_RegeneratesOnCollision(t *testing.T) {
  408. setupConflictDB(t)
  409. seedInboundConflictNode(t, "inbound-5000-tcp", "0.0.0.0", 5000, model.VLESS, `{"network":"tcp"}`, `{}`, nil)
  410. svc := &InboundService{}
  411. pushed := &model.Inbound{
  412. Tag: "inbound-5000-tcp",
  413. Listen: "0.0.0.0",
  414. Port: 5000,
  415. Protocol: model.Hysteria,
  416. StreamSettings: ``,
  417. Settings: ``,
  418. }
  419. got, err := svc.resolveInboundTag(pushed, 0)
  420. if err != nil {
  421. t.Fatalf("resolveInboundTag: %v", err)
  422. }
  423. if got == "inbound-5000-tcp" {
  424. t.Fatalf("colliding caller tag must be replaced, but resolver kept %q", got)
  425. }
  426. }
  427. // inbounds bound to a remote node get the canonical tag prefixed with
  428. // "n<id>-" so the same listen+port+transport can live on the central
  429. // panel and on the node simultaneously without bumping the global
  430. // UNIQUE(inbounds.tag) constraint.
  431. func TestGenerateInboundTag_NodePrefix(t *testing.T) {
  432. setupConflictDB(t)
  433. svc := &InboundService{}
  434. in := &model.Inbound{
  435. Listen: "0.0.0.0",
  436. Port: 443,
  437. Protocol: model.VLESS,
  438. NodeID: intPtr(1),
  439. }
  440. got, err := svc.generateInboundTag(in, 0)
  441. if err != nil {
  442. t.Fatalf("generateInboundTag: %v", err)
  443. }
  444. if got != "n1-inbound-443-tcp" {
  445. t.Fatalf("expected n1-inbound-443-tcp, got %q", got)
  446. }
  447. }
  448. // a node-prefixed inbound shouldn't collide with a same-port local one:
  449. // the prefix scopes the tag to that specific node.
  450. func TestGenerateInboundTag_NodePrefixedDoesNotCollideWithLocal(t *testing.T) {
  451. setupConflictDB(t)
  452. seedInboundConflict(t, "inbound-443-tcp", "0.0.0.0", 443, model.VLESS, `{"network":"tcp"}`, `{}`)
  453. svc := &InboundService{}
  454. in := &model.Inbound{
  455. Listen: "0.0.0.0",
  456. Port: 443,
  457. Protocol: model.VLESS,
  458. NodeID: intPtr(1),
  459. }
  460. got, err := svc.generateInboundTag(in, 0)
  461. if err != nil {
  462. t.Fatalf("generateInboundTag: %v", err)
  463. }
  464. if got != "n1-inbound-443-tcp" {
  465. t.Fatalf("expected n1-inbound-443-tcp, got %q", got)
  466. }
  467. }
  468. // updating an inbound must not see itself as a conflict, that's what
  469. // ignoreId is for.
  470. func TestCheckPortConflict_IgnoreSelfOnUpdate(t *testing.T) {
  471. setupConflictDB(t)
  472. seedInboundConflict(t, "vless-443", "0.0.0.0", 443, model.VLESS, `{"network":"tcp"}`, `{}`)
  473. var existing model.Inbound
  474. if err := database.GetDB().Where("tag = ?", "vless-443").First(&existing).Error; err != nil {
  475. t.Fatalf("read seeded row: %v", err)
  476. }
  477. svc := &InboundService{}
  478. if exist, err := svc.checkPortConflict(&existing, existing.Id); err != nil || exist != nil {
  479. t.Fatalf("self-update must not be flagged as conflict; exist=%v err=%v", exist, err)
  480. }
  481. }
  482. // streamSettings.network=quic rides on UDP at L4, so a QUIC inbound must
  483. // conflict with a UDP-only neighbour (hysteria) on the same port but not
  484. // with a TCP-only one. covers the gap left by the original kcp-only check.
  485. func TestCheckPortConflict_QUICTreatedAsUDP(t *testing.T) {
  486. quic := &model.Inbound{
  487. Tag: "vless-quic-443",
  488. Listen: "0.0.0.0",
  489. Port: 443,
  490. Protocol: model.VLESS,
  491. StreamSettings: `{"network":"quic"}`,
  492. }
  493. t.Run("conflicts with hysteria/udp", func(t *testing.T) {
  494. setupConflictDB(t)
  495. seedInboundConflict(t, "hyst-443", "0.0.0.0", 443, model.Hysteria, ``, ``)
  496. svc := &InboundService{}
  497. if exist, err := svc.checkPortConflict(quic, 0); err != nil || exist == nil {
  498. t.Fatalf("quic on same port as hysteria must conflict; exist=%v err=%v", exist, err)
  499. }
  500. })
  501. t.Run("coexists with vless/tcp", func(t *testing.T) {
  502. setupConflictDB(t)
  503. seedInboundConflict(t, "vless-tcp-443", "0.0.0.0", 443, model.VLESS, `{"network":"tcp"}`, `{}`)
  504. svc := &InboundService{}
  505. if exist, err := svc.checkPortConflict(quic, 0); err != nil || exist != nil {
  506. t.Fatalf("quic and tcp on same port must coexist; exist=%v err=%v", exist, err)
  507. }
  508. })
  509. }
  510. // tunnel (dokodemo-door) carries its L4 transport list in
  511. // settings.allowedNetwork, not settings.network. verify the predicate
  512. // picks the right field for each protocol.
  513. func TestCheckPortConflict_TunnelAllowedNetwork(t *testing.T) {
  514. setupConflictDB(t)
  515. seedInboundConflict(t, "tunnel-udp-443", "0.0.0.0", 443, model.Tunnel, ``, `{"allowedNetwork":"udp"}`)
  516. svc := &InboundService{}
  517. // tcp inbound on same port should coexist with udp-only tunnel.
  518. tcpNeighbour := &model.Inbound{
  519. Tag: "vless-443",
  520. Listen: "0.0.0.0",
  521. Port: 443,
  522. Protocol: model.VLESS,
  523. StreamSettings: `{"network":"tcp"}`,
  524. }
  525. if exist, err := svc.checkPortConflict(tcpNeighbour, 0); err != nil || exist != nil {
  526. t.Fatalf("tunnel/udp and vless/tcp on same port must coexist; exist=%v err=%v", exist, err)
  527. }
  528. // udp neighbour (hysteria) on same port must conflict.
  529. udpNeighbour := &model.Inbound{
  530. Tag: "hyst-443",
  531. Listen: "0.0.0.0",
  532. Port: 443,
  533. Protocol: model.Hysteria,
  534. }
  535. if exist, err := svc.checkPortConflict(udpNeighbour, 0); err != nil || exist == nil {
  536. t.Fatalf("tunnel/udp and hysteria on same port must conflict; exist=%v err=%v", exist, err)
  537. }
  538. }
  539. // the rich conflict detail surfaced to the user must name the offending
  540. // inbound (by remark when available) and the shared L4 transport(s).
  541. func TestCheckPortConflict_DetailMessage(t *testing.T) {
  542. setupConflictDB(t)
  543. seeded := &model.Inbound{
  544. Tag: "vless-443",
  545. Remark: "my-vless",
  546. Enable: true,
  547. Listen: "0.0.0.0",
  548. Port: 443,
  549. Protocol: model.VLESS,
  550. StreamSettings: `{"network":"tcp"}`,
  551. Settings: `{}`,
  552. }
  553. if err := database.GetDB().Create(seeded).Error; err != nil {
  554. t.Fatalf("seed inbound: %v", err)
  555. }
  556. svc := &InboundService{}
  557. candidate := &model.Inbound{
  558. Tag: "trojan-443",
  559. Listen: "0.0.0.0",
  560. Port: 443,
  561. Protocol: model.Trojan,
  562. StreamSettings: `{"network":"ws"}`,
  563. }
  564. got, err := svc.checkPortConflict(candidate, 0)
  565. if err != nil || got == nil {
  566. t.Fatalf("expected conflict, got=%v err=%v", got, err)
  567. }
  568. msg := got.String()
  569. if !strings.Contains(msg, "my-vless") {
  570. t.Fatalf("message should mention the conflicting inbound's remark; got %q", msg)
  571. }
  572. if !strings.Contains(msg, "tcp") {
  573. t.Fatalf("message should mention the shared L4 transport; got %q", msg)
  574. }
  575. if !strings.Contains(msg, "443") {
  576. t.Fatalf("message should mention the port; got %q", msg)
  577. }
  578. }