process.go 22 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764
  1. package xray
  2. import (
  3. "bytes"
  4. "context"
  5. "encoding/json"
  6. "errors"
  7. "fmt"
  8. "os"
  9. "os/exec"
  10. "path/filepath"
  11. "runtime"
  12. "sort"
  13. "strings"
  14. "sync"
  15. "sync/atomic"
  16. "syscall"
  17. "time"
  18. "github.com/mhsanaei/3x-ui/v3/internal/config"
  19. "github.com/mhsanaei/3x-ui/v3/internal/logger"
  20. "github.com/mhsanaei/3x-ui/v3/internal/util/common"
  21. )
  22. // GetBinaryName returns the Xray binary filename for the current OS and architecture.
  23. func GetBinaryName() string {
  24. arch := runtime.GOARCH
  25. if arch == "arm" {
  26. arch = "arm32"
  27. }
  28. return fmt.Sprintf("xray-%s-%s", runtime.GOOS, arch)
  29. }
  30. // GetBinaryPath returns the full path to the Xray binary executable.
  31. func GetBinaryPath() string {
  32. return config.GetBinFolderPath() + "/" + GetBinaryName()
  33. }
  34. // GetConfigPath returns the path to the Xray configuration file in the binary folder.
  35. func GetConfigPath() string {
  36. return config.GetBinFolderPath() + "/config.json"
  37. }
  38. // GetGeositePath returns the path to the geosite data file used by Xray.
  39. func GetGeositePath() string {
  40. return config.GetBinFolderPath() + "/geosite.dat"
  41. }
  42. // GetGeoipPath returns the path to the geoip data file used by Xray.
  43. func GetGeoipPath() string {
  44. return config.GetBinFolderPath() + "/geoip.dat"
  45. }
  46. // GetIPLimitLogPath returns the path to the IP limit log file.
  47. func GetIPLimitLogPath() string {
  48. return config.GetLogFolder() + "/3xipl.log"
  49. }
  50. // GetIPLimitBannedLogPath returns the path to the banned IP log file.
  51. func GetIPLimitBannedLogPath() string {
  52. return config.GetLogFolder() + "/3xipl-banned.log"
  53. }
  54. // GetIPLimitBannedPrevLogPath returns the path to the previous banned IP log file.
  55. func GetIPLimitBannedPrevLogPath() string {
  56. return config.GetLogFolder() + "/3xipl-banned.prev.log"
  57. }
  58. func getLogPath(key string) (string, error) {
  59. config, err := os.ReadFile(GetConfigPath())
  60. if err != nil {
  61. logger.Warningf("Failed to read configuration file: %s", err)
  62. return "", err
  63. }
  64. jsonConfig := map[string]any{}
  65. err = json.Unmarshal(config, &jsonConfig)
  66. if err != nil {
  67. logger.Warningf("Failed to parse JSON configuration: %s", err)
  68. return "", err
  69. }
  70. if jsonLog, ok := jsonConfig["log"].(map[string]any); ok {
  71. if logPath, ok := jsonLog[key].(string); ok {
  72. return logPath, nil
  73. }
  74. }
  75. return "", err
  76. }
  77. // GetAccessLogPath reads the Xray config and returns the access log file path.
  78. func GetAccessLogPath() (string, error) {
  79. return getLogPath("access")
  80. }
  81. // GetErrorLogPath reads the Xray config and returns the error log file path.
  82. // GetErrorLogPath reads the Xray config and returns the error log file path.
  83. func GetErrorLogPath() (string, error) {
  84. return getLogPath("error")
  85. }
  86. // stopProcess calls Stop on the given Process instance.
  87. func stopProcess(p *Process) {
  88. _ = p.Stop()
  89. }
  90. // Process wraps an Xray process instance and provides management methods.
  91. type Process struct {
  92. *process
  93. }
  94. // NewProcess creates a new Xray process and sets up cleanup on garbage collection.
  95. func NewProcess(xrayConfig *Config) *Process {
  96. p := &Process{newProcess(xrayConfig)}
  97. runtime.SetFinalizer(p, stopProcess)
  98. return p
  99. }
  100. // NewTestProcess creates a new Xray process that uses a specific config file path.
  101. // Used for test runs (e.g. outbound test) so the main config.json is not overwritten.
  102. // The config file at configPath is removed when the process is stopped.
  103. func NewTestProcess(xrayConfig *Config, configPath string) *Process {
  104. p := &Process{newTestProcess(xrayConfig, configPath)}
  105. runtime.SetFinalizer(p, stopProcess)
  106. return p
  107. }
  108. type process struct {
  109. // mu guards the process lifecycle fields (cmd, done, exitErr) plus version and
  110. // apiPort, which are written by Start/startCommand/refreshVersion/refreshAPIPort
  111. // while being read concurrently by IsRunning/GetErr/GetResult/GetXrayVersion/
  112. // GetAPIPort/Stop from other goroutines (status endpoint, check-xray-running
  113. // and traffic jobs). Snapshot under the lock, then do any blocking syscall
  114. // (Wait/Signal/Kill) on the local copy without holding it.
  115. mu sync.RWMutex
  116. cmd *exec.Cmd
  117. done chan struct{}
  118. version string
  119. apiPort int
  120. // onlineClients is the set of emails active on THIS panel's own xray
  121. // within the online grace window. It is derived only from local xray
  122. // traffic polls (see RefreshLocalOnline) — never from remote-node
  123. // snapshots — so a client connected solely to a remote node is not
  124. // reported online on local inbounds.
  125. onlineClients []string
  126. // localActiveInbounds is the set of THIS panel's inbound tags that
  127. // carried traffic within the same grace window. Xray's user>>>email
  128. // stat aggregates across every inbound a client is attached to, so an
  129. // online email alone can't say which inbound it actually used. Pairing
  130. // it with the inbound>>>tag stat lets the per-inbound view drop a
  131. // multi-inbound client from inbounds that saw no traffic this window.
  132. localActiveInbounds []string
  133. // localLastOnline records, per email, the last time this panel's own
  134. // xray reported traffic for it. RefreshLocalOnline rebuilds
  135. // onlineClients from this map each tick, keeping the local online set
  136. // independent of the shared client_traffics.last_online column — that
  137. // column is bumped by remote-node syncs too and would otherwise leak
  138. // remote-only clients into the local set.
  139. localLastOnline map[string]int64
  140. // localInboundLastActive mirrors localLastOnline for inbound tags: the
  141. // last tick this panel's xray reported traffic through each tag.
  142. // Rebuilt into localActiveInbounds under the same grace window so the
  143. // two signals stay aligned — an email within grace always has the
  144. // inbound it used within grace too.
  145. localInboundLastActive map[string]int64
  146. // nodeOnlineTrees holds, per direct remote node (keyed by that node's
  147. // panel-local id), the GUID-keyed online-emails subtree that node
  148. // reported — its own clients under its panelGuid plus every descendant
  149. // under theirs. Keying the stored value by GUID (not node id) lets the
  150. // master attribute a deeply nested client to the node that physically
  151. // hosts it across a chain (#4983); the outer node-id key is only so a
  152. // failed probe can drop that whole branch's contribution. NodeTrafficSyncJob
  153. // populates entries per cron tick and clears them when a probe fails. The
  154. // mutex guards this map, onlineClients, and localLastOnline above so the
  155. // online getters never see a torn read.
  156. nodeOnlineTrees map[int]map[string][]string
  157. onlineMu sync.RWMutex
  158. // onlineAPISupport caches whether the running core implements the
  159. // online-stats RPCs (GetUsersStats). A new process is created on every
  160. // restart/version switch, so the flag resets to Unknown and is re-probed
  161. // lazily by the first caller.
  162. onlineAPISupport atomic.Int32
  163. config *Config
  164. configPath string // if set, use this path instead of GetConfigPath() and remove on Stop
  165. logWriter *LogWriter
  166. exitErr error
  167. startTime time.Time
  168. intentionalStop atomic.Bool
  169. }
  170. // OnlineAPISupport describes whether the running Xray core implements the
  171. // online-stats API (statsUserOnline + GetUsersStats).
  172. type OnlineAPISupport int32
  173. const (
  174. // OnlineAPIUnknown means support has not been probed yet for this process.
  175. OnlineAPIUnknown OnlineAPISupport = iota
  176. // OnlineAPISupported means the core answered the online-stats RPC.
  177. OnlineAPISupported
  178. // OnlineAPIUnsupported means the core returned Unimplemented (older binary).
  179. OnlineAPIUnsupported
  180. )
  181. // OnlineAPISupport returns the cached online-stats capability of this process.
  182. func (p *process) OnlineAPISupport() OnlineAPISupport {
  183. return OnlineAPISupport(p.onlineAPISupport.Load())
  184. }
  185. // SetOnlineAPISupport records the probed online-stats capability of this process.
  186. func (p *process) SetOnlineAPISupport(v OnlineAPISupport) {
  187. p.onlineAPISupport.Store(int32(v))
  188. }
  189. var (
  190. xrayGracefulStopTimeout = 5 * time.Second
  191. xrayForceStopTimeout = 2 * time.Second
  192. // OnCrash is called when xray crashes unexpectedly. Set from web layer.
  193. OnCrash func(err error)
  194. )
  195. // newProcess creates a new internal process struct for Xray.
  196. func newProcess(config *Config) *process {
  197. return &process{
  198. version: "Unknown",
  199. config: config,
  200. logWriter: NewLogWriter(),
  201. startTime: time.Now(),
  202. }
  203. }
  204. // newTestProcess creates a process that writes and runs with a specific config path.
  205. func newTestProcess(config *Config, configPath string) *process {
  206. p := newProcess(config)
  207. p.configPath = configPath
  208. return p
  209. }
  210. // IsRunning returns true if the Xray process is currently running.
  211. func (p *process) IsRunning() bool {
  212. p.mu.RLock()
  213. cmd, done := p.cmd, p.done
  214. p.mu.RUnlock()
  215. if cmd == nil || cmd.Process == nil {
  216. return false
  217. }
  218. // done is closed by the waitForCommand goroutine exactly when cmd.Wait
  219. // returns, i.e. when the process has exited; it is the race-free signal here
  220. // (reading cmd.ProcessState would race with that Wait).
  221. if done != nil {
  222. select {
  223. case <-done:
  224. return false
  225. default:
  226. }
  227. }
  228. return true
  229. }
  230. // GetErr returns the last error encountered by the Xray process.
  231. func (p *process) GetErr() error {
  232. p.mu.RLock()
  233. defer p.mu.RUnlock()
  234. return p.exitErr
  235. }
  236. // GetResult returns the last log line or error from the Xray process.
  237. func (p *process) GetResult() string {
  238. p.mu.RLock()
  239. exitErr := p.exitErr
  240. p.mu.RUnlock()
  241. lastLine := p.logWriter.LastLine()
  242. if len(lastLine) == 0 && exitErr != nil {
  243. return exitErr.Error()
  244. }
  245. return lastLine
  246. }
  247. // GetXrayVersion returns the version string of the Xray process.
  248. func (p *process) GetXrayVersion() string {
  249. p.mu.RLock()
  250. defer p.mu.RUnlock()
  251. return p.version
  252. }
  253. // GetAPIPort returns the API port used by the Xray process.
  254. func (p *Process) GetAPIPort() int {
  255. p.mu.RLock()
  256. defer p.mu.RUnlock()
  257. return p.apiPort
  258. }
  259. // GetConfig returns the configuration used by the Xray process.
  260. func (p *Process) GetConfig() *Config {
  261. return p.config
  262. }
  263. // SetConfig replaces the stored configuration snapshot after the running
  264. // process has been reconciled with it through the gRPC API (hot apply), so
  265. // later change detection compares against what is actually running.
  266. func (p *Process) SetConfig(config *Config) {
  267. p.config = config
  268. }
  269. // GetOnlineClients returns the union of locally-online clients and
  270. // node-online clients from every registered remote panel. Dedupes by
  271. // email so a client connected to both a local and a node-managed inbound
  272. // surfaces once. Cheap allocation — typical online sets are small and
  273. // the union is recomputed on demand.
  274. func (p *Process) GetOnlineClients() []string {
  275. p.onlineMu.RLock()
  276. defer p.onlineMu.RUnlock()
  277. if len(p.nodeOnlineTrees) == 0 {
  278. // Hot path for single-panel deployments: avoid the map+dedupe
  279. // work entirely and return the local slice as-is.
  280. return p.onlineClients
  281. }
  282. seen := make(map[string]struct{}, len(p.onlineClients))
  283. out := make([]string, 0, len(p.onlineClients))
  284. add := func(emails []string) {
  285. for _, email := range emails {
  286. if _, dup := seen[email]; dup {
  287. continue
  288. }
  289. seen[email] = struct{}{}
  290. out = append(out, email)
  291. }
  292. }
  293. add(p.onlineClients)
  294. for _, tree := range p.nodeOnlineTrees {
  295. for _, emails := range tree {
  296. add(emails)
  297. }
  298. }
  299. return out
  300. }
  301. // GetLocalOnlineClients returns a copy of the emails online on THIS panel's own
  302. // xray within the grace window. The service layer keys these under the panel's
  303. // own GUID when assembling the per-node online view.
  304. func (p *Process) GetLocalOnlineClients() []string {
  305. p.onlineMu.RLock()
  306. defer p.onlineMu.RUnlock()
  307. if len(p.onlineClients) == 0 {
  308. return nil
  309. }
  310. out := make([]string, len(p.onlineClients))
  311. copy(out, p.onlineClients)
  312. return out
  313. }
  314. // GetMergedNodeTrees returns the union of every direct node's reported subtree,
  315. // keyed by the panelGuid of the node that physically hosts each client set.
  316. // Because each child already reports its descendants under their own GUIDs,
  317. // merging the direct children yields the whole tree at any depth (#4983), so a
  318. // client three hops down is attributed to its real node, not the intermediate
  319. // one. GUIDs are globally unique, but a set reported under the same GUID by more
  320. // than one path is deduped per key; empty sets are omitted.
  321. func (p *Process) GetMergedNodeTrees() map[string][]string {
  322. p.onlineMu.RLock()
  323. defer p.onlineMu.RUnlock()
  324. if len(p.nodeOnlineTrees) == 0 {
  325. return map[string][]string{}
  326. }
  327. out := make(map[string][]string)
  328. seen := make(map[string]map[string]struct{})
  329. for _, tree := range p.nodeOnlineTrees {
  330. for guid, emails := range tree {
  331. if guid == "" || len(emails) == 0 {
  332. continue
  333. }
  334. dedup := seen[guid]
  335. if dedup == nil {
  336. dedup = make(map[string]struct{}, len(emails))
  337. seen[guid] = dedup
  338. }
  339. for _, email := range emails {
  340. if _, ok := dedup[email]; ok {
  341. continue
  342. }
  343. dedup[email] = struct{}{}
  344. out[guid] = append(out[guid], email)
  345. }
  346. }
  347. }
  348. return out
  349. }
  350. // GetLocalActiveInbounds returns a copy of THIS panel's inbound tags that
  351. // carried traffic within the grace window. Only the local xray reports
  352. // per-inbound activity; remote-node snapshots don't carry it, so the service
  353. // layer keys these under the panel's own GUID and a node missing from the
  354. // active-inbounds map means "don't gate" (fall back to the email-only signal).
  355. func (p *Process) GetLocalActiveInbounds() []string {
  356. p.onlineMu.RLock()
  357. defer p.onlineMu.RUnlock()
  358. if len(p.localActiveInbounds) == 0 {
  359. return nil
  360. }
  361. out := make([]string, len(p.localActiveInbounds))
  362. copy(out, p.localActiveInbounds)
  363. return out
  364. }
  365. // RefreshLocalOnline records that each email in activeEmails and each tag in
  366. // activeInboundTags had local xray traffic at now, then rebuilds onlineClients
  367. // and localActiveInbounds from every entry seen within graceMs, pruning older
  368. // ones. Called by the local XrayTrafficJob after each xray gRPC stats poll.
  369. // Pass nil/empty slices to only prune — NodeTrafficSyncJob does this so a
  370. // stopped local xray's clients and inbounds still age out between local polls.
  371. func (p *Process) RefreshLocalOnline(activeEmails, activeInboundTags []string, now, graceMs int64) {
  372. p.onlineMu.Lock()
  373. defer p.onlineMu.Unlock()
  374. if p.localLastOnline == nil {
  375. p.localLastOnline = make(map[string]int64, len(activeEmails))
  376. }
  377. for _, email := range activeEmails {
  378. p.localLastOnline[email] = now
  379. }
  380. online := make([]string, 0, len(p.localLastOnline))
  381. for email, ts := range p.localLastOnline {
  382. if now-ts < graceMs {
  383. online = append(online, email)
  384. } else {
  385. delete(p.localLastOnline, email)
  386. }
  387. }
  388. p.onlineClients = online
  389. if p.localInboundLastActive == nil {
  390. p.localInboundLastActive = make(map[string]int64, len(activeInboundTags))
  391. }
  392. for _, tag := range activeInboundTags {
  393. p.localInboundLastActive[tag] = now
  394. }
  395. activeInbounds := make([]string, 0, len(p.localInboundLastActive))
  396. for tag, ts := range p.localInboundLastActive {
  397. if now-ts < graceMs {
  398. activeInbounds = append(activeInbounds, tag)
  399. } else {
  400. delete(p.localInboundLastActive, tag)
  401. }
  402. }
  403. p.localActiveInbounds = activeInbounds
  404. }
  405. // SetNodeOnlineTree records the GUID-keyed online subtree one direct remote
  406. // node reported (its own clients under its panelGuid plus every descendant
  407. // under theirs). Replaces any previous entry for that node — NodeTrafficSyncJob
  408. // always sends the full subtree per tick.
  409. func (p *Process) SetNodeOnlineTree(nodeID int, tree map[string][]string) {
  410. p.onlineMu.Lock()
  411. defer p.onlineMu.Unlock()
  412. if p.nodeOnlineTrees == nil {
  413. p.nodeOnlineTrees = map[int]map[string][]string{}
  414. }
  415. p.nodeOnlineTrees[nodeID] = tree
  416. }
  417. // ClearNodeOnlineClients drops a direct node's whole subtree contribution.
  418. // Called when a probe fails so a downed node — and everything behind it — doesn't
  419. // keep its clients listed as "online" until the next successful probe.
  420. func (p *Process) ClearNodeOnlineClients(nodeID int) {
  421. p.onlineMu.Lock()
  422. defer p.onlineMu.Unlock()
  423. delete(p.nodeOnlineTrees, nodeID)
  424. }
  425. // GetUptime returns the uptime of the Xray process in seconds.
  426. func (p *Process) GetUptime() uint64 {
  427. return uint64(time.Since(p.startTime).Seconds())
  428. }
  429. // refreshAPIPort updates the API port from the inbound configs.
  430. func (p *process) refreshAPIPort() {
  431. port := 0
  432. for _, inbound := range p.config.InboundConfigs {
  433. if inbound.Tag == "api" {
  434. port = inbound.Port
  435. break
  436. }
  437. }
  438. p.mu.Lock()
  439. p.apiPort = port
  440. p.mu.Unlock()
  441. }
  442. // refreshVersion updates the version string by running the Xray binary with -version.
  443. func (p *process) refreshVersion() {
  444. version := "Unknown"
  445. cmd := exec.CommandContext(context.Background(), GetBinaryPath(), "-version")
  446. if data, err := cmd.Output(); err == nil {
  447. if datas := bytes.Split(data, []byte(" ")); len(datas) > 1 {
  448. version = string(datas[1])
  449. }
  450. }
  451. p.mu.Lock()
  452. p.version = version
  453. p.mu.Unlock()
  454. }
  455. // Start launches the Xray process with the current configuration.
  456. func (p *process) Start() (err error) {
  457. if p.IsRunning() {
  458. return errors.New("xray is already running")
  459. }
  460. defer func() {
  461. if err != nil {
  462. logger.Error("Failure in running xray-core process: ", err)
  463. p.setExitErr(err)
  464. }
  465. }()
  466. data, err := json.MarshalIndent(p.config, "", " ")
  467. if err != nil {
  468. return common.NewErrorf("Failed to generate XRAY configuration files: %v", err)
  469. }
  470. err = os.MkdirAll(config.GetLogFolder(), 0o770)
  471. if err != nil {
  472. logger.Warningf("Failed to create log folder: %s", err)
  473. }
  474. configPath := GetConfigPath()
  475. if p.configPath != "" {
  476. configPath = p.configPath
  477. }
  478. err = writeFileAtomic(configPath, data, 0o600)
  479. if err != nil {
  480. return common.NewErrorf("Failed to write configuration file: %v", err)
  481. }
  482. cmd := exec.CommandContext(context.Background(), GetBinaryPath(), "-c", configPath)
  483. cmd.Stdout = p.logWriter
  484. cmd.Stderr = p.logWriter
  485. err = p.startCommand(cmd)
  486. if err != nil {
  487. return err
  488. }
  489. p.refreshVersion()
  490. p.refreshAPIPort()
  491. return nil
  492. }
  493. // writeFileAtomic writes data to path via a same-directory temp file that is
  494. // permissioned, synced, and renamed into place, so a crash can never leave a
  495. // partial config; the config holds credentials, hence the 0600 perm. After the
  496. // rename the parent directory is fsynced to persist the directory entry. That
  497. // final step is skipped on Windows, where directory fsync is unsupported and
  498. // os.Rename already uses replace-existing semantics.
  499. func writeFileAtomic(path string, data []byte, perm os.FileMode) (err error) {
  500. dir := filepath.Dir(path)
  501. tmp, err := os.CreateTemp(dir, ".config-*.tmp")
  502. if err != nil {
  503. return err
  504. }
  505. tmpPath := tmp.Name()
  506. defer func() {
  507. _ = tmp.Close()
  508. if err != nil {
  509. _ = os.Remove(tmpPath)
  510. }
  511. }()
  512. if err = tmp.Chmod(perm); err != nil {
  513. return err
  514. }
  515. if _, err = tmp.Write(data); err != nil {
  516. return err
  517. }
  518. if err = tmp.Sync(); err != nil {
  519. return err
  520. }
  521. if err = tmp.Close(); err != nil {
  522. return err
  523. }
  524. if err = renameFile(tmpPath, path); err != nil {
  525. return err
  526. }
  527. if runtime.GOOS == "windows" {
  528. return nil
  529. }
  530. dirHandle, err := os.Open(dir)
  531. if err != nil {
  532. return err
  533. }
  534. err = dirHandle.Sync()
  535. _ = dirHandle.Close()
  536. return err
  537. }
  538. var renameFile = os.Rename
  539. func (p *process) startCommand(cmd *exec.Cmd) error {
  540. p.mu.Lock()
  541. p.cmd = cmd
  542. p.done = make(chan struct{})
  543. p.exitErr = nil
  544. done := p.done
  545. p.mu.Unlock()
  546. p.intentionalStop.Store(false)
  547. if err := cmd.Start(); err != nil {
  548. close(done)
  549. p.mu.Lock()
  550. p.cmd = nil
  551. p.mu.Unlock()
  552. return err
  553. }
  554. attachChildLifetime(cmd)
  555. go p.waitForCommand(cmd, done)
  556. return nil
  557. }
  558. func (p *process) setExitErr(err error) {
  559. p.mu.Lock()
  560. p.exitErr = err
  561. p.mu.Unlock()
  562. }
  563. func (p *process) waitForCommand(cmd *exec.Cmd, done chan struct{}) {
  564. defer close(done)
  565. err := cmd.Wait()
  566. if err == nil || p.intentionalStop.Load() {
  567. return
  568. }
  569. // On Windows, killing the process results in "exit status 1" which isn't an error for us.
  570. if runtime.GOOS == "windows" {
  571. errStr := strings.ToLower(err.Error())
  572. if strings.Contains(errStr, "exit status 1") {
  573. p.setExitErr(err)
  574. return
  575. }
  576. }
  577. logger.Error("Failure in running xray-core:", err)
  578. p.setExitErr(err)
  579. if OnCrash != nil {
  580. OnCrash(err)
  581. }
  582. }
  583. // Stop terminates the running Xray process.
  584. func (p *process) Stop() error {
  585. if !p.IsRunning() {
  586. return errors.New("xray is not running")
  587. }
  588. p.intentionalStop.Store(true)
  589. // Snapshot cmd once, then run the blocking Signal/Kill/Wait on the local copy
  590. // without holding the lock.
  591. p.mu.RLock()
  592. cmd := p.cmd
  593. p.mu.RUnlock()
  594. if cmd == nil || cmd.Process == nil {
  595. return errors.New("xray is not running")
  596. }
  597. // Remove temporary config file used for test runs so main config is never touched
  598. if p.configPath != "" {
  599. if p.configPath != GetConfigPath() {
  600. // Check if file exists before removing
  601. if _, err := os.Stat(p.configPath); err == nil {
  602. _ = os.Remove(p.configPath)
  603. }
  604. }
  605. }
  606. if runtime.GOOS == "windows" {
  607. if err := cmd.Process.Kill(); err != nil && !errors.Is(err, os.ErrProcessDone) {
  608. return err
  609. }
  610. return p.waitForExit(xrayForceStopTimeout)
  611. }
  612. if err := cmd.Process.Signal(syscall.SIGTERM); err != nil {
  613. if errors.Is(err, os.ErrProcessDone) {
  614. return p.waitForExit(xrayForceStopTimeout)
  615. }
  616. return err
  617. }
  618. if err := p.waitForExit(xrayGracefulStopTimeout); err == nil {
  619. return nil
  620. }
  621. logger.Warning("xray-core did not stop after SIGTERM, killing process")
  622. if err := cmd.Process.Kill(); err != nil && !errors.Is(err, os.ErrProcessDone) {
  623. return err
  624. }
  625. return p.waitForExit(xrayForceStopTimeout)
  626. }
  627. func (p *process) waitForExit(timeout time.Duration) error {
  628. p.mu.RLock()
  629. done := p.done
  630. p.mu.RUnlock()
  631. if done == nil {
  632. return nil
  633. }
  634. timer := time.NewTimer(timeout)
  635. defer timer.Stop()
  636. select {
  637. case <-done:
  638. return nil
  639. case <-timer.C:
  640. return common.NewErrorf("timed out waiting for xray-core process to stop after %s", timeout)
  641. }
  642. }
  643. const (
  644. crashReportPrefix = "core_crash_"
  645. crashReportSuffix = ".log"
  646. maxCrashReports = 10
  647. )
  648. // writeCrashReport persists a captured xray crash chunk to the log folder
  649. // with nanosecond-precision filename so restart-loop bursts don't overwrite
  650. // each other, and prunes old reports to keep the folder bounded.
  651. func writeCrashReport(m []byte) error {
  652. dir := config.GetLogFolder()
  653. if err := os.MkdirAll(dir, 0o770); err != nil {
  654. return err
  655. }
  656. pruneOldCrashReports(dir, maxCrashReports-1)
  657. name := crashReportPrefix + time.Now().Format("20060102_150405_000000000") + crashReportSuffix
  658. return os.WriteFile(filepath.Join(dir, name), m, 0o640)
  659. }
  660. func pruneOldCrashReports(dir string, keep int) {
  661. entries, err := os.ReadDir(dir)
  662. if err != nil {
  663. return
  664. }
  665. var reports []string
  666. for _, e := range entries {
  667. n := e.Name()
  668. if !e.IsDir() && strings.HasPrefix(n, crashReportPrefix) && strings.HasSuffix(n, crashReportSuffix) {
  669. reports = append(reports, n)
  670. }
  671. }
  672. if len(reports) <= keep {
  673. return
  674. }
  675. sort.Strings(reports)
  676. for _, old := range reports[:len(reports)-keep] {
  677. _ = os.Remove(filepath.Join(dir, old))
  678. }
  679. }