Fix Kitsu toasting "Logged in" when there is an error (#4329)

app/src/main/java/eu/kanade/tachiyomi/data/track/kitsu/Kitsu.kt

@@ -101,14 +101,10 @@ class Kitsu(private val context: Context, id: Int) : TrackService(id) {
     }
 
     override suspend fun login(username: String, password: String) {
-        try {
-            val token = api.login(username, password)
-            interceptor.newAuth(token)
-            val userId = api.getCurrentUser()
-            saveCredentials(username, userId)
-        } catch (e: Throwable) {
-            logout()
-        }
+        val token = api.login(username, password)
+        interceptor.newAuth(token)
+        val userId = api.getCurrentUser()
+        saveCredentials(username, userId)
     }
 
     override fun logout() {

app/src/main/java/eu/kanade/tachiyomi/ui/setting/track/TrackLoginDialog.kt

@@ -48,6 +48,7 @@ class TrackLoginDialog(
                 dialog?.dismiss()
                 withUIContext { view?.context?.toast(R.string.login_success) }
             } catch (e: Throwable) {
+                service.logout()
                 binding?.login?.progress = -1
                 binding?.login?.setText(R.string.unknown_error)
                 withUIContext { e.message?.let { view?.context?.toast(it) } }