Browse Source

Remove some usages of global scope

arkon 2 years ago
parent
commit
8efb20439a

+ 2 - 2
app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/browse/BrowseSourceController.kt

@@ -595,7 +595,7 @@ open class BrowseSourceController(bundle: Bundle) :
     override fun onItemLongClick(position: Int) {
         val activity = activity ?: return
         val manga = (adapter?.getItem(position) as? SourceItem?)?.manga ?: return
-        launchIO {
+        viewScope.launchIO {
             val duplicateManga = presenter.getDuplicateLibraryManga(manga)
 
             withUIContext {
@@ -631,7 +631,7 @@ open class BrowseSourceController(bundle: Bundle) :
 
     private fun addToLibrary(newManga: Manga, position: Int) {
         val activity = activity ?: return
-        launchIO {
+        viewScope.launchIO {
             val categories = presenter.getCategories()
             val defaultCategoryId = preferences.defaultCategory()
             val defaultCategory = categories.find { it.id == defaultCategoryId.toLong() }

+ 1 - 1
app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/browse/BrowseSourcePresenter.kt

@@ -194,7 +194,7 @@ open class BrowseSourcePresenter(
         if (!hasNextPage()) return
 
         nextPageJob?.cancel()
-        nextPageJob = launchIO {
+        nextPageJob = presenterScope.launchIO {
             try {
                 pager.requestNextPage()
             } catch (e: Throwable) {

+ 1 - 1
app/src/main/java/eu/kanade/tachiyomi/ui/manga/MangaPresenter.kt

@@ -920,7 +920,7 @@ class MangaPresenter(
 
     fun trackingSearch(query: String, service: TrackService) {
         searchTrackerJob?.cancel()
-        searchTrackerJob = launchIO {
+        searchTrackerJob = presenterScope.launchIO {
             try {
                 val results = service.search(query)
                 withUIContext { view?.onTrackingSearchResults(results) }

+ 1 - 1
app/src/main/java/eu/kanade/tachiyomi/ui/reader/ReaderPresenter.kt

@@ -249,7 +249,7 @@ class ReaderPresenter(
     fun init(mangaId: Long, initialChapterId: Long) {
         if (!needsInit()) return
 
-        launchIO {
+        presenterScope.launchIO {
             try {
                 val manga = getManga.await(mangaId)
                 withUIContext {

+ 0 - 2
app/src/main/java/eu/kanade/tachiyomi/ui/setting/track/TrackLoginDialog.kt

@@ -21,8 +21,6 @@ class TrackLoginDialog(
 
     private val service = Injekt.get<TrackManager>().getService(args.getLong("serviceId"))!!
 
-    constructor(service: TrackService) : this(service, null)
-
     constructor(service: TrackService, @StringRes usernameLabelRes: Int?) :
         this(usernameLabelRes, bundleOf("serviceId" to service.id))