Эх сурвалжийг харах

Fix crash in chapters list #159

inorichi 9 жил өмнө
parent
commit
b33da641d9

+ 9 - 0
app/src/main/java/eu/kanade/tachiyomi/ui/manga/chapter/ChaptersFragment.java

@@ -100,6 +100,15 @@ public class ChaptersFragment extends BaseRxFragment<ChaptersPresenter> implemen
         return view;
     }
 
+    @Override
+    public void onPause() {
+        // Stop recycler's scrolling when onPause is called. If the activity is finishing
+        // the presenter will be destroyed, and it could cause NPE
+        // https://github.com/inorichi/tachiyomi/issues/159
+        recyclerView.stopScroll();
+        super.onPause();
+    }
+
     @Override
     public void onCreateOptionsMenu(Menu menu, MenuInflater inflater) {
         inflater.inflate(R.menu.chapters, menu);

+ 1 - 1
app/src/main/java/eu/kanade/tachiyomi/ui/manga/chapter/ChaptersPresenter.java

@@ -38,7 +38,7 @@ public class ChaptersPresenter extends BasePresenter<ChaptersFragment> {
     @Inject PreferencesHelper preferences;
     @Inject DownloadManager downloadManager;
 
-    @State Manga manga;
+    private Manga manga;
     private Source source;
     private List<Chapter> chapters;
     @State boolean hasRequested;