Bladeren bron

Fix extension setting dialogs not handling duplicate keys (fixes #2876)

arkon 5 jaren geleden
bovenliggende
commit
c2330fe3af
1 gewijzigde bestanden met toevoegingen van 4 en 1 verwijderingen
  1. 4 1
      app/src/main/java/eu/kanade/tachiyomi/ui/extension/ExtensionDetailsController.kt

+ 4 - 1
app/src/main/java/eu/kanade/tachiyomi/ui/extension/ExtensionDetailsController.kt

@@ -191,8 +191,11 @@ class ExtensionDetailsController(bundle: Bundle? = null) :
         f.showDialog(router)
     }
 
+    @Suppress("UNCHECKED_CAST")
     override fun <T : Preference> findPreference(key: CharSequence): T? {
-        return preferenceScreen!!.findPreference(key)
+        // We track [lastOpenPreferencePosition] when displaying the dialog
+        // [key] isn't useful since there may be duplicates
+        return preferenceScreen!!.getPreference(lastOpenPreferencePosition!!) as T
     }
 
     private companion object {